Skip to content

brcmfmac: fix firmware crash due to mismatched completion handlers #7460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelwell merged 1 commit into from
Jun 29, 2026
+4 −1
Merged

brcmfmac: fix firmware crash due to mismatched completion handlers #7460

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
/*
* Copyright (c) 2022 Broadcom Corporation
*/
#include <linux/atomic.h>
#include <linux/errno.h>
#include <linux/types.h>
#include <core.h>
Expand All @@ -23,6 +24,8 @@
#define MGMT_AUTH_FRAME_DWELL_TIME 4000
#define MGMT_AUTH_FRAME_WAIT_TIME (MGMT_AUTH_FRAME_DWELL_TIME + 100)

static atomic_t brcmf_cyw_mgmt_tx_id = ATOMIC_INIT(0);

static int brcmf_cyw_set_sae_pwd(struct brcmf_if *ifp,
struct cfg80211_crypto_settings *crypto)
{
Expand Down Expand Up @@ -124,7 +127,7 @@ int brcmf_cyw_mgmt_tx(struct wiphy *wiphy, struct wireless_dev *wdev,
if (!ieee80211_is_auth(mgmt->frame_control))
return brcmf_cfg80211_mgmt_tx(wiphy, wdev, params, cookie);

*cookie = 0;
*cookie = (u32)atomic_inc_return(&brcmf_cyw_mgmt_tx_id);
vif = container_of(wdev, struct brcmf_cfg80211_vif, wdev);

reinit_completion(&vif->mgmt_tx);
Expand Down
Loading