edatec Open Source‌ HMI for 7 inches panel driver by spp-bruk · Pull Request #7361 · raspberrypi/linux

spp-bruk · 2026-05-13T10:03:08Z

this is 7 inches panel driver please check them,thanks

pelwell

This looks fairly close to being ready, although I know that @6by9 has some feedback about the driver.

As an overall comment for both PRs, we like our submissions to be split into three parts:

driver code, Kconfig and Makefile
Device Tree, overlays, README and Makefile
_defconfig changes

pelwell · 2026-05-13T10:32:09Z

+	};
+
+	fragment@4 {
+		target = <&i2c_arm>;


There are probably plenty of examples of using &i2c_arm and &i2c1 in the same overlay, but let's be consistent - make this &i2c1 to match the parameter name.

pelwell · 2026-05-13T10:46:46Z

 CONFIG_SCHED_TRACER=y
 CONFIG_STRICT_DEVMEM=y
 CONFIG_TEST_KSTRTOX=y
+CONFIG_DRM_PANEL_EDATEC_7INCH=m


bcm2835_defconfig is the upstream defconfig for Pi 1s and Pi Zeros. As of rpi-6.18.y we use:

arch/arm/configs/bcmrpi_defconfig // Pi 1, Pi Zero

arch/arm/configs/bcm2709_defconfig // Pi 2, Pi 3, Pi Zero 2

arch/arm64/configs/bcm2711_defconfig // Pi 3, Pi 4, Pi 5, Pi Zero 2

arch/arm64/configs/bcm2711_rt_defconfig // RealTime kernel for Pi 3, Pi 4, Pi 5, Pi Zero 2

arch/arm64/configs/bcm2712_defconfig // Pi 5 only (16kB pages)

To generate _defconfig files:

Run e.g. make ARCH=arm ... bcmrpi_defconfig.

Make the changes to .config in any of the usual ways.

Run make ARCH=arm ... savedefconfig.

Copy the output file, defconfig, back to e.g. arch/arm/configs/bcmrpi_defconfig.

Ok, i will use myself defconfig and don't modify bcm2835_defconfig

6by9 · 2026-05-13T13:39:16Z

+	return 0;
+}
+
+static int ed_panel_unprepare(struct drm_panel *panel)


unprepare is optional. Don't define it if it does nothing.

i see . i will delete it

6by9 · 2026-05-13T13:39:28Z

+}
+
+static int ed_panel_prepare(struct drm_panel *panel)
+{


prepare is optional. Don't define it if it does nothing.

i see . i will delete it

6by9 · 2026-05-13T13:45:42Z

+static int ed_panel_disable(struct drm_panel *panel)
+{
+	struct ed_panel *ts = panel_to_ts(panel);
+	ed_panel_i2c_write(ts, CMD_BACKLIGHT_EN, 0x00);


You have a backlight device defined. Associate the display with the backlight and the backlight driver will get called by the framework driver as the panel is enabled/disabled.

You are doing this with the 10" panel branch, so reuse that regulator driver here, and use panel-simple to configure the panel.

in our project backlight is control by mcu not soc . soc will tell mcu backlight level by i2c . mcu will read i2c and save date in queue.mcu thread will access queue and adjust light by pwm

6by9 · 2026-05-13T13:48:20Z

+	msgs[0].len = 16;
+	msgs[0].buf = data_buf;
+
+	ret = i2c_transfer(i2c->adapter, msgs, ARRAY_SIZE(msgs));


Do you need to do separate write and read transactions for this? The Pi panel had to as the MCU misbehaved with clock stretching and could lock the bus.

we write some data by i2c tell ic mcu i want do something. ic mcu will run by itself, the i read some reg by i2c get some message , write and read op is sequential operation . between write and read will delay some time. this is no some diffirent with separate write and read . we can delay more time if we need

6by9 · 2026-05-13T13:50:31Z

+	/* This appears last, as it's what will unblock the DSI host
+	 * driver's component bind function.
+	 */
+	drm_panel_add(&ts->base);


drm_panel_add only adds the panel to a list. If unblocks nothing.

You're probably referring to devm_mipi_dsi_attach

drm_panel_add will add this panel to list. so other module can get drm_panel by list. eg TPIC get panel on/off by notify chain with drm_panel. devm_mipi_dsi_attach is bind dsi and panel. as usally this two api all be used ,eg panel-ilitek-ili79600a.c , panel-elida-kd35t133.c

6by9 · 2026-05-13T14:01:46Z

+		goto error;
+	}
+
+	if(ts->mode->clock > 42000)


Please provide details of what this is doing.

I'd hazard a guess that it's switching something between rzw,t70p383rk-v2 and rzw,t70p383rk-lite mode, in which case do it by having struct of_device_id data point to a struct that includes this value and a pointer to the drm_display_mode, not inferring it from the clock.

because cm0 and cm4 dsi frq is diffirent , so this logic is diffirent. i will modify as you mean

6by9 · 2026-05-13T14:22:58Z

+#define CMD_FW_VERSION		0xE1
+
+#define PIN_LCD_BL_EN	BIT(0)
+#define PIN_LCD_BL_PWM	BIT(1)


Is this pin actually used as a GPIO, or only as PWM? If only PWM then it shouldn't be exposed as a GPIO.

this is GPIO control mcu pwm, in our project DDIC and backlight power is control by mcu not soc

6by9 · 2026-05-13T14:51:17Z

+}
+
+static int ed_gpio_get(struct gpio_chip *gc, unsigned int off)
+{


Ditto to the query over ed_direction_input, is it really supported and useful to have these GPIOs as inputs that can be read?

we define a few‌ gpios ,only support output communicate with mcu . in fact mcu some gpio not open ,so we have to do this at here

6by9 · 2026-05-13T14:54:26Z

+			<&gt911>,"interrupts:0",
+			<&gt911>,"irq-gpios:4";
+
+		pi4 = <&i2c_frag>, "target:0=",<&i2c_csi_dsi>;


2c_frag target defaults to i2c_csi_dsi, so why do we need the pi4, cm4 and pi5 overrides? Just document that the defaults work for those platforms?

i will ask former colleague . if this is any other use, i will delete them

i asked former colleague, he tell me that : our product support multiple platforms PI4/CM4 PI5/CM5 CM0 ，we put them in one dts config

6by9 · 2026-05-13T15:21:51Z

+	.vtotal = 600 + 12 + 3 + 20,
+};
+
+static const struct drm_display_mode ed_panel_7_0_cm0_mode = {


I can make guesses as to why the different mode, but please confirm.

The guess is that on CM0 (and CM1 and 3) the parent PLL to DSI is 2GHz and can only integer divide. CM4 is 3GHz.
We need a DSI clock of (pixel clock * 24 / 2), so on CM0 41000 will become 2GHz /4 to give 41666kHz with a small fixup on the HFP.
For CM4 with a 3GHz PLL, /6 would also give a 41666kHz pixel clock. (The 50000kHz clock above is achievable directly with a /5)

The first mode also appears to end up with a refresh rate of 58.58Hz, whereas this cm0 mode is 60.33Hz. What's the desired refresh rate?

yes it is .
cm0 ratefres = 41000000 /（1114 * 610）about 60.33HZ
cm4 ratefres = 50000000 / （1344 × 635）about 58.58HZ

Signed-off-by: lzunspp <bli@edatec.cn>

pelwell reviewed May 13, 2026

View reviewed changes

6by9 reviewed May 13, 2026

View reviewed changes

spp-bruk force-pushed the edatec_7 branch from ec0ea9b to 2038ffb Compare May 14, 2026 08:44

feat(display): edatec Open Source‌ HMI for 7 inches panel driver

a5b3565

Signed-off-by: lzunspp <bli@edatec.cn>

spp-bruk force-pushed the edatec_7 branch from 2038ffb to a5b3565 Compare May 14, 2026 09:05

spp-bruk changed the title ~~eadtec Open Source‌ HMI for 7 inches panel driver~~ edatec Open Source‌ HMI for 7 inches panel driver May 14, 2026

Conversation

spp-bruk commented May 13, 2026

Uh oh!

pelwell left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

spp-bruk May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

spp-bruk May 14, 2026 •

edited

Loading