Bump org.springframework.boot from 3.5.7 to 4.0.2#325
Bump org.springframework.boot from 3.5.7 to 4.0.2#325
Conversation
Summary of ChangesHello @rashidi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a significant dependency upgrade, moving the project to Spring Boot 4.0.2. This upgrade necessitated updates to various Spring Boot starters, Testcontainers libraries, and other core dependencies. A key change is the removal of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Job Summary for GradleGradle Build :: gradle-build
|
Job Summary for GradleGradle Build :: gradle-build
|
There was a problem hiding this comment.
Code Review
This pull request primarily focuses on upgrading Spring Boot to version 4.0.2, which necessitated numerous dependency updates, package renames, and the introduction of new starter dependencies across various modules. Key changes include updating Testcontainers, Jackson, and Spring Batch related packages, as well as migrating configuration in cloud-jdbc-env-repo from bootstrap.yml to application.yml. Additionally, the test-rest-assured module has been entirely removed. While most changes are straightforward dependency and package updates, there's a notable change in Author.java where @GeneratedValue was removed from an embedded ID, which could have functional implications. Overall, the changes reflect a necessary upgrade path, but attention should be paid to the ID generation behavior.
| static class Id implements Serializable { | ||
|
|
||
| @GeneratedValue | ||
| private Long id; |
There was a problem hiding this comment.
The @GeneratedValue annotation was removed from the id field within the Id embeddable class. If this ID was previously intended to be automatically generated by the persistence provider (e.g., database sequence or identity column), its removal means the ID will no longer be generated. This could lead to null IDs or other data integrity issues if the application logic does not explicitly assign a value to this ID before persistence. Please confirm if this change is intentional and if there's an alternative mechanism for ID generation or assignment in place.
| @@ -68,7 +69,7 @@ void findAll() { | |||
| assertThat(execution.getExitStatus()).isEqualTo(COMPLETED); | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
Changing the lambda parameter from _ to i is a good practice for clarity, even if the parameter is not directly used within the lambda body. It improves readability by explicitly naming the parameter, which can be helpful for future maintainers understanding the lambda's signature.
var users = jdbc.query("SELECT * FROM users", (rs, i) ->| app.greet.name: Default | ||
| spring: | ||
| application.name: demo | ||
| cloud.config.server: | ||
| bootstrap: true | ||
| jdbc: | ||
| sql: SELECT `KEY`, `VALUE` from PROPERTIES where APPLICATION=? and PROFILE=? and LABEL=? | ||
| sql-without-profile: SELECT `KEY`, `VALUE` from PROPERTIES where APPLICATION=? and PROFILE='default' and LABEL=? | ||
| profiles.active: jdbc No newline at end of file |
There was a problem hiding this comment.
The migration of configuration from bootstrap.yml to application.yml and the change in YAML structure from nested to flat for app.greet.name is a significant refactoring. While bootstrap.yml is deprecated in newer Spring Boot versions, ensuring all configurations are correctly translated and behave as expected is crucial. The flat property app.greet.name is a more concise way to define simple properties.
Job Summary for GradleGradle Build :: gradle-build
|
Job Summary for GradleGradle Build :: gradle-build
|
Job Summary for GradleGradle Build :: gradle-build
|
No description provided.