Skip to content

[POC] added a hook for checking secrets with coderabbit gitleaks#116

Closed
mmccarty wants to merge 1 commit intorapidsai:mainfrom
mmccarty:coderabbit-gitleaks-hook
Closed

[POC] added a hook for checking secrets with coderabbit gitleaks#116
mmccarty wants to merge 1 commit intorapidsai:mainfrom
mmccarty:coderabbit-gitleaks-hook

Conversation

@mmccarty
Copy link

@mmccarty mmccarty commented Feb 3, 2026

No description provided.

@KyleFromNVIDIA
Copy link
Member

In my opinion, this kind of thing isn't well-suited for the RAPIDS pre-commit-hooks repository. This repo is meant for things that are highly RAPIDS-specific, like ensuring the copyright info is correct, making sure we don't have hard-coded RAPIDS versions, etc. Coderabbit with GitLeaks is used by other projects and developers as well, so perhaps we should request a pre-commit hook from upstream. If upstream won't provide one, we should make a separate repository for it, or at the very least, rework the hook to not use Python at all (it's an unneeded layer of indirection IMHO), and just invoke Coderabbit directly from .pre-commit-hooks.yaml.

Please let me know what you think.

@mmccarty
Copy link
Author

mmccarty commented Feb 4, 2026

Yeah, that's fair. I have another version that just uses bash. its much simplier

@mmccarty mmccarty closed this Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants