[POC] added a hook for checking secrets with coderabbit gitleaks#116
[POC] added a hook for checking secrets with coderabbit gitleaks#116mmccarty wants to merge 1 commit intorapidsai:mainfrom
Conversation
|
In my opinion, this kind of thing isn't well-suited for the RAPIDS pre-commit-hooks repository. This repo is meant for things that are highly RAPIDS-specific, like ensuring the copyright info is correct, making sure we don't have hard-coded RAPIDS versions, etc. Coderabbit with GitLeaks is used by other projects and developers as well, so perhaps we should request a pre-commit hook from upstream. If upstream won't provide one, we should make a separate repository for it, or at the very least, rework the hook to not use Python at all (it's an unneeded layer of indirection IMHO), and just invoke Coderabbit directly from Please let me know what you think. |
|
Yeah, that's fair. I have another version that just uses bash. its much simplier |
No description provided.