Skip to content

Add session tags#221

Merged
adfoster-r7 merged 1 commit intorapid7:masterfrom
sjanusz-r7:add-session-tagging
Mar 5, 2026
Merged

Add session tags#221
adfoster-r7 merged 1 commit intorapid7:masterfrom
sjanusz-r7:add-session-tagging

Conversation

@sjanusz-r7
Copy link
Copy Markdown
Contributor

This PR is a pre-requisite for adding session tags to Pro

#

# @see http://stackoverflow.com/a/11694704
after_destroy :destroy_orphan_tag
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paper trail comment, nothing actionable, dup'd code:

t.integer :session_id
t.integer :tag_id
end
add_index :sessions_tags, [:session_id, :tag_id], unique: true
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taken from the Pro PR:

In PgAdmin4, we do not have an index.

image

so I'm unsure if this is expected or not.

@sjanusz-r7 sjanusz-r7 marked this pull request as ready for review March 5, 2026 15:58
@adfoster-r7 adfoster-r7 merged commit 0537312 into rapid7:master Mar 5, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants