Skip to content

Use GitHub HTTP URL as Maven scm url#1887

Merged
raphw merged 1 commit intoraphw:masterfrom
Marcono1234:maven-scm-url
Mar 7, 2026
Merged

Use GitHub HTTP URL as Maven scm url#1887
raphw merged 1 commit intoraphw:masterfrom
Marcono1234:maven-scm-url

Conversation

@Marcono1234
Copy link
Contributor

According to https://maven.apache.org/pom.html#SCM the url should be "a publicly browsable repository", and the example also uses an HTTP URL.

For example on https://central.sonatype.com/artifact/net.bytebuddy/byte-buddy the previous value lead to a malformed "Source Control" link.

Note that the scm url is also affected by #718 though.

According to https://maven.apache.org/pom.html#SCM the `url` should be
"a publicly browsable repository", and the example also uses an HTTP URL.
@M-PRANAY
Copy link

M-PRANAY commented Mar 6, 2026

Shouldn't the url direct to https://bytebuddy.net/#/ instead of github project?

@Marcono1234
Copy link
Contributor Author

This PR is specifically about the scm (source code management) url, so using the GitHub URL seems appropriate.

The top-level url already points to the website:

<url>https://bytebuddy.net</url>

@M-PRANAY
Copy link

M-PRANAY commented Mar 6, 2026

the byte-buddy should refer to https://bytebuddy.net from https://central.sonatype.com/artifact/net.bytebuddy/byte-buddy, but it redirects to a broken https://bytebuddy.net/byte-buddy;

@Marcono1234
Copy link
Contributor Author

That is #718, as mentioned above. This PR here does not try to fix that.

Copy link
Owner

@raphw raphw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks.

@raphw raphw merged commit 9a1e34e into raphw:master Mar 7, 2026
8 checks passed
@Marcono1234 Marcono1234 deleted the maven-scm-url branch March 9, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants