Docker unified healthcheck#526
Closed
av1nDs0uza wants to merge 2 commits intorajnandan1:mainfrom
Closed
Conversation
Author
|
Hi , Just checking if there’s anything I should tweak or clarify on this PR? Happy to make updates |
Owner
|
This I have implement in v4, so declining. thanks for taking your time for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: I haven’t fully tested running the container on Windows, so there might still be some quirks there, but the main goal of unifying the scripts is done. I apologise if this causes the maintainer issues, this is my first contribution and will happily accept any feedback or suggestions