Enable fine-grained visibility controls for group members#460
Closed
ericmeadows wants to merge 11 commits intorajnandan1:mainfrom
Closed
Enable fine-grained visibility controls for group members#460ericmeadows wants to merge 11 commits intorajnandan1:mainfrom
ericmeadows wants to merge 11 commits intorajnandan1:mainfrom
Conversation
…manage its own visibility
…age and there are components that will be hidden
Author
|
@rajnandan1 - can you take a look? |
rajnandan1
reviewed
Aug 5, 2025
| */ | ||
| export function up(knex) { | ||
| return knex.schema.alterTable("monitors", function (table) { | ||
| table.boolean("enable_details_to_be_examined").notNullable().defaultTo(true); |
Owner
There was a problem hiding this comment.
let us tiny int for this, since there are nuances of how boolean is interpreted for pg/mysql/sqilite
Owner
|
can you add some screen shots |
Owner
|
This i will take up next in v4, so declining. thanks for taking your time for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #415
In order to add somewhat fine-grained display functionality, we have submitted the work we did internally to limit certain monitors from being publicly visible within groups. This allows teams to expand the items in a healthcheck without displaying those results publicly. This is somewhat similar, but more-enhanced, functionality from Kuma Uptime. In order to accomplish this, there needed to be a "two-way" switch that allows for one setting to override the other - members of a group can set their own visibility in a group setting, and the parent can turn off the visibility for all children.
Here's the rough user story/specification:
Here's the functionality checklist:
*when logged-in to let users know it's not visible publiclyPossible future functionality (feel free to request this if really needed):
*on the main page when the drill-down is going to be disabled publicly*means