Clarify that concurrency + bulk enqueuing is a perf caveat, not unsafe - #785
Merged
Merged
Conversation
"is not a good idea" reads as a correctness warning; limits are in fact always respected, so the only downside is losing the bulk speedup. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
|
Good call, thanks @Gnirt! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swapped "is not a good idea" → "has no benefit" so readers don't come away thinking concurrency limits might be violated under bulk enqueuing.
The README currently says mixing concurrency controls with
perform_all_later"is not a good idea". That phrasing reads as a correctness/safety warning, but the very same sentence explains the limits are respected — concurrency-controlled jobs are just enqueued one by one internally. The only real consequence is losing the bulk-enqueue speedup for those jobs.