Handle data-confirm attribute in elements that submit forms#5
Open
twalpole wants to merge 1 commit intorails:masterfrom
Open
Handle data-confirm attribute in elements that submit forms#5twalpole wants to merge 1 commit intorails:masterfrom
twalpole wants to merge 1 commit intorails:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle data-confirm attribute added by ActionView::Helpers::FormTagHelper#submit_tag, image_submit_tag, and button_tag. The existing code appears to check for the data-confirm attribute on the form element, which doesnt appear to be correct according to the options listed for form_tag in the rails api docs, but I'm not 100% sure so I havent removed that