fix assert_select wanting something to call .css on

[grosser]

@pschambacher

[grosser]

otherwise

assert_select_rjs do
        assert_select "#1"
end

fails with nasty undefined method css for Array :(

[pschambacher]

Yes please

[grosser]

@rafaelfranca this is some old 💩 but we still need that :D

[rafaelfranca]

Could you add a test case?

[rafaelfranca]

Does this gem depends on Nokogiri? I don't think so. If we want to use nokogiri we need to make it a dependency

[grosser]

yeah I guess you are right ... this is too dirty
... I'll just leave this here as docs and try again to kill prototype instead :/

[rafaelfranca]

What I did in Shopify was to keep the prototype JavaScript code and just remove all ruby methods calls that we had.

[grosser]

I think we are ready to remove prototype ... lots of old routes gone now ... so maybe worth a new try :)

…

On Thu, Jun 15, 2017 at 2:52 PM, Rafael França ***@***.***> wrote: What I did in Shopify was to keep the prototype JavaScript code and just remove all ruby methods calls that we had. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#39 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAsZ5lCjHaPYZQn5_FIER9dyLO7eSkVks5sEaewgaJpZM4HwuGW> .