fix: missing . in temp file which leads creating extensionless file#146
Open
tomocrafter wants to merge 1 commit intorails:masterfrom
Open
fix: missing . in temp file which leads creating extensionless file#146tomocrafter wants to merge 1 commit intorails:masterfrom
. in temp file which leads creating extensionless file#146tomocrafter wants to merge 1 commit intorails:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've encountered to an situation that this issue may introduce js error depends on runtime.
Since bun runtime will default to TS/TSX if extension is missing in passed file name, then it will incorrectly parse js file as ts file (normally, this wont and should make any difference but I also found an issue in bun's transpiler that it changes code's behavior).
https://github.com/oven-sh/bun/blob/e9e93244cb3fee8bc4d734e7a4f3f2883eb1bf4a/src/bun.js/ModuleLoader.zig#L1015-L1017