stat_tracking: fix AttributeError on second update() call caused by in-place np.stack overwrite#3
Open
Dev-X25874 wants to merge 1 commit into
Open
Conversation
…n-place np.stack overwrite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PerPromptStatTracker.update()crashes withAttributeError: 'numpy.ndarray' object has no attribute 'extend'on any call after the first when the sameprompt key is seen again.
Root Cause
The second
forloop inupdate()overwritesself.stats[prompt]with theresult of
np.stack(...), converting the stored value from alistto anumpy.ndarray. On the next call, the firstforloop tries to call.extend()on that ndarray, which does not exist on that type.Fix
Compute the stacked array into a local variable
prompt_historyinstead ofoverwriting
self.stats[prompt], so the list is preserved across calls.All downstream mean/std calculations use
prompt_history; no values change.Impact
accumulation (
train_sd3.py,train_flux.py,train_flux_fast.py, etc.)main()smoke test only callsupdate()once beforeclear(),so the bug was not caught locally