Skip to content

Revamp/gather args infer#2

Open
Rockdu wants to merge 4 commits into
mainfrom
revamp/gather_args_infer
Open

Revamp/gather args infer#2
Rockdu wants to merge 4 commits into
mainfrom
revamp/gather_args_infer

Conversation

@Rockdu
Copy link
Copy Markdown
Collaborator

@Rockdu Rockdu commented May 13, 2026

This pr:

  1. move all implicit args inference logics into arguments.py for clear references (getattr(args, "xxx", default_val), (args.xxx or None), etc), so that almost all arguments are determined after argument parsing phase.
  2. update_weight_target_module was originally set in arguments.py, but actually related to specific models. This pr absorb update_weight_target_module into TrainPipelineConfig

@Rockdu Rockdu requested review from Ying1123 and guapisolo as code owners May 13, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant