Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rack::Attack.reset!no longer raisesIncompatibleStoreErrorfor cache stores that don't supportdelete_matched(e.g., SolidCache). Instead, it fallsback to a prefix rotation strategy that orphans old keys. Stores that fully support
delete_matchedare completely unaffected.Motivation
SolidCache inherits from
ActiveSupport::Cache::Storewhich definesdelete_matchedbut raisesNotImplementedError. This meansreset!fails even thoughall runtime operations (
read,write,increment,delete) work fine. Sincereset!is primarily a test helper for clearing state between runs, itshouldn't make an otherwise functional store "incompatible".
How it works
reset!attempts to calldelete_matchedas beforeNotImplementedError(e.g., SolidCache inheriting ActiveSupport's stub) orNoMethodError(store doesn't define it at all), it fallsback to prefix rotation
"rack::attack:generation"and incremented on each fallbackreset!effective_prefixthat includes the generation (e.g.,rack::attack:g1:...) when generation > 0, making old keys inaccessibleIncompatibleStoreErrorremains defined but is no longer raised, avoiding breakage for code that rescues it