perf(approvers): Reduce approver's pipeline allocations#700
Merged
Conversation
The approver path is allocation heavy, because we have to clone the CreateFile event so it can outlive the ETW callback. To alleviate the pressure on the heap allocator, we agressively pool the event records, their data buffers, and callstack return addresses.
rabbitstack
force-pushed
the
reduce-approvers-allocations
branch
from
July 17, 2026 17:21
37e0fc1 to
1b4c413
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR / why it is needed?
The approver path is allocation-heavy because we have to clone the CreateFile event so it can outlive the ETW callback. To alleviate the pressure on the heap allocator, we aggressively pool the event records, their data buffers, and the callstack return
addresses.
List of optimizations:
strings.ToLowerfrom the hot pathWhat type of change does this PR introduce?
/kind improvement
Any specific area of the project related to this PR?
/area instrumentation
/area rule-engine
Special notes for the reviewer
Does this PR introduce a user-facing change?