PemReader: follow-up improvements#1903
Merged
michaelklishin merged 4 commits intomainfrom Mar 12, 2026
Merged
Conversation
This improves regular expression patterns, error handling and logging in `PemReader`. References #1840.
Contributor
Author
|
@hgeraldino FYI. Please don't take this as any form of criticism, I just assume that as a contributor and a user of this feature you'd like to be up-to-date with its follow-up updates. |
Contributor
Author
|
The failures are unrelated and have to do with changes in RabbitMQ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves regular expression patterns (to be non-greedy and less susceptible to a certain class of attacks), error handling and corrects error logging in
PemReader.References #1840.
Note: tests fail due to changes in RabbitMQ
main#1906.