Skip to content

Restore saved-audio speaker recovery - #1693

Closed
r3dbars wants to merge 2 commits into
mainfrom
codex/fix-1681-speaker-recovery
Closed

Restore saved-audio speaker recovery#1693
r3dbars wants to merge 2 commits into
mainfrom
codex/fix-1681-speaker-recovery

Conversation

@r3dbars

@r3dbars r3dbars commented Aug 13, 2026

Copy link
Copy Markdown
Owner

Summary

  • allow retained-audio re-transcription while speaker review is pending
  • keep active dictation, recording, model-preparation, and background-work guards
  • preserve focused coverage for recovery from a failed speaker-finalization state

Fixes #1681

Verification

  • bash scripts/dev/agent-preflight.sh — passed
  • bash run-tests.sh --filter RecentCaptureScannersTests — 133 passed
  • bash run-tests.sh — 12,194 passed
  • bash build-deps.sh --force — passed; existing compiler warnings only
  • bash build.sh --no-open — passed; signature and launch smoke passed
  • bash run-integration-smoke.sh — passed; core, wake, and recovery-merge smoke passed
  • swift test — skipped; no Core/public SwiftPM seam changed

Independent review

  • codex review --uncommitted was started against the true origin/main HEAD and stopped after approximately three minutes without producing a final verdict. Review timeout is recorded here rather than blocking the PR.
  • Rejected findings: none; no completed reviewer findings were available to reject.

Manual real-device reproduction with the affected retained audio was not run and remains unknown.

@r3dbars

r3dbars commented Aug 21, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #1696. The replacement adds exact request-owner fencing, stale-finalizer isolation, retained-audio preservation through validated startup, and the required deterministic regressions. #1696 remains draft because the full fast-test gate and live affected-artifact proof are still open.

@r3dbars r3dbars closed this Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Speaker naming finalization failure leaves saved meeting stuck with disabled speaker playback and retranscription

1 participant