Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
Yeah, probably. I just need to get into the right headspace to push through the display challenges and finish this off. |
Member
Author
|
Oh except I'll need a translation for the link title and I have just asked all the translators to update 😞. So probably this will need to come later. |
salim-b
reviewed
Jun 23, 2024
Comment on lines
+33
to
+37
| x %in% c( | ||
| "base", "compiler", "datasets", "graphics", "grDevices", "grid", | ||
| "methods", "parallel", "splines", "stats", "stats4", "tcltk", | ||
| "tools", "utils" | ||
| ) |
Collaborator
There was a problem hiding this comment.
Maybe better use x %in% rownames(installed.packages(priority="base"))?
cf. https://stackoverflow.com/questions/21567057/programmatically-get-list-of-base-packages
| if (is_base_package(package)) { | ||
| href <- NA | ||
| } else { | ||
| href <- paste0("https://cran.r-project.org/web/packages/", package) |
Collaborator
There was a problem hiding this comment.
I think CRAN would rather want us to create canonical links like
href <- paste0(" https://CRAN.R-project.org/package=", package)(hostname is case-insensitive, of course)
|
|
||
| if (is.na(href)) { | ||
| if (is_base_package(package)) { | ||
| href <- NA |
Collaborator
There was a problem hiding this comment.
For base R packages, we could link to one of the unofficial documentation renderings, e.g.
https://r-universe.dev/manuals/PKG.html(example: https://r-universe.dev/manuals/parallel.html)https://rdrr.io/r/#PKG(example: https://rdrr.io/r/#parallel)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix #1333