Skip to content

remove envvar printing from check_built() #2621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tanho63 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

remove envvar printing from check_built() #2621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4ddb6e8
remove check-envvar-print from check_built() - r-lib/rcmdcheck#237
tanho63 Sep 21, 2025
fa5cdb5
update news
tanho63 Sep 21, 2025
ce045e9
Merged origin/main into tanho63-tan/tdd-rcmdcheck-237
hadley Jan 21, 2026
d0865e4
Move bullet to correct place
hadley Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# devtools (development version)

* `check_built()` no longer prints `R_CHECK_` check env variables - now handled by `rcmdcheck::rcmdcheck()` directly as of r-lib/rcmdcheck#237 (#2621)
* `is_loading()` is now re-exported from pkgload (#2556).
* `load_all()` now errors if called recursively, i.e. if you accidentally include a `load_all()` call in one of your R source files (#2617).

Expand Down
4 changes: 0 additions & 4 deletions R/check.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,10 +221,6 @@ check_built <- function(
}

env_vars <- check_env_vars(cran, remote, incoming, force_suggests, env_vars)
if (!quiet) {
cat_rule("Checking", col = "cyan", line = 2)
show_env_vars(env_vars)
Copy link
Member

@hadley hadley Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See here I'd explicitly filter out _R_CHECK_ env vars since we know that rcmdcheck will handle them.

}

withr::with_envvar(env_vars, action = "replace", {
rcmdcheck::rcmdcheck(
Expand Down