Open
Conversation
|
@quirkey any updates on this? Would love to keep logger in my project. |
Author
|
@MatthewSH I didn't hear back, but logger is working like a charm for me. I forked it and just dropped the code in a file to my codebase with the edit; I'm no longer using it as an NPM dependency. I made one other edit to logger (in my code) after this pull request: changed a system.out.println() to console.log() for the same reason. |
|
I actually ended up doing the same right after I saw the lack of activity. Shame. Wish he could mark someone else as a maintainer so people could update it.
… On May 13, 2018, at 11:31 PM, Brad Garner ***@***.***> wrote:
@MatthewSH I didn't hear back, but logger is working like a charm for me. I forked it and just dropped the code in a file to my codebase with the edit; I'm no longer using it as an NPM dependency. I made one other edit to logger (in my code) after this pull request: changed a system.out.println() to console.log() for the same reason.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
I was about to make the same merge request but i'm happy to see someone else did. Hope the author will accept you modifications soon ! |
faizanktk
approved these changes
Jul 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
line 32 of logger.js required 'sys', which is deprecated. Updated to require 'util'.