Remove broken Saved Scenario Reports feature#4750
Open
aaccensi wants to merge 1 commit into
Open
Conversation
Deletes the CSV report controller, view, FetchAPIScenarioQueries service, ovm.yml report config, route, and the now-orphaned Engine::Query model. Broken since saved scenarios moved to MyETM. Fixes #4669
noracato
reviewed
Jul 14, 2026
Member
There was a problem hiding this comment.
This was just orphaned anyways right?
Member
Author
There was a problem hiding this comment.
yes, this was just old orphaned files and a route
noracato
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
While removing the Energy Mix infographic and adding the deprecation notice to the Scenario Report feature, some queries turned up that belonged to a different, forgotten feature: a CSV export for saved scenarios (/saved_scenarios/:id/report/:report_name) driven by a YAML query template. It dates from when saved scenarios still lived in etmodel and has been broken since they moved to MyETM. It has been broken for a long time with no complaints, so this PR removes it entirely rather than fixing it.
Implemented changes
SavedScenarioReportsController(broken CSV report controller)app/views/saved_scenario_reports/show.csv.erbFetchAPIScenarioQueriesservice and its spec (only used by this controller)config/saved_scenario_reports/ovm.yml, the only report config (directory deleted too)get '/report/:report_name' => 'saved_scenario_reports#show'fromconfig/routes.rbEngine::Querymodel — orphaned once the service was deleted (its sole consumer)Related
Closes #4669
Checklist