Replace ctrl+enter with cmd+enter for mac on firefox#1781
Open
louispt1 wants to merge 1 commit into
Open
Conversation
Member
|
I like it and it works, thanks for fixing it. Only question: wouldn't we rather kill the ctrl + return function then? |
Member
Author
|
Well only if we are always only on mac as admins? Which is currently true but maybe not always? |
Member
|
On Windows the Cmd button is replaced by the Windows button right? As a non-confusing alternative, shouldn't we just facilitate Option (Mac) and Alt (Windows)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Because of Firefox issues with ctrl+enter (see: https://bugzilla.mozilla.org/show_bug.cgi?id=237027) I have extended the command to also accept cmd+enter. For me this works perfectly well and can be considered an MVP solution.
Note: ctrl+enter still acts as a right click for me. I also have that behaviour on other pages (e.g. gmail).
What do you think @mabijkerk ?
Checklist