Skip to content

Replace ctrl+enter with cmd+enter for mac on firefox#1781

Open
louispt1 wants to merge 1 commit into
masterfrom
gql-submit
Open

Replace ctrl+enter with cmd+enter for mac on firefox#1781
louispt1 wants to merge 1 commit into
masterfrom
gql-submit

Conversation

@louispt1

Copy link
Copy Markdown
Member

Context

Because of Firefox issues with ctrl+enter (see: https://bugzilla.mozilla.org/show_bug.cgi?id=237027) I have extended the command to also accept cmd+enter. For me this works perfectly well and can be considered an MVP solution.

Note: ctrl+enter still acts as a right click for me. I also have that behaviour on other pages (e.g. gmail).

What do you think @mabijkerk ?

Checklist

  • I have tested these changes
  • I have updated documentation as needed
  • I have tagged the relevant people for review

@louispt1 louispt1 requested a review from mabijkerk July 15, 2026 13:47
@mabijkerk

Copy link
Copy Markdown
Member

I like it and it works, thanks for fixing it.

Only question: wouldn't we rather kill the ctrl + return function then?

Copy link
Copy Markdown
Member Author

Well only if we are always only on mac as admins? Which is currently true but maybe not always?

@mabijkerk

Copy link
Copy Markdown
Member

On Windows the Cmd button is replaced by the Windows button right? As a non-confusing alternative, shouldn't we just facilitate Option (Mac) and Alt (Windows)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants