search: fix trace fragmentation and restructure spans#6620
Draft
loutPhilipps wants to merge 1 commit into
Draft
Conversation
- nest per-split spans under `multi_index_leaf_search` - add more granularity: `plan_splits_for_root_search`, `list_relevant_splits`, `fetch_docs_in_split`, and a per-split wrapper (`leaf_search_single_split_wrapper`) so each split's wait + warmup + tantivy form one subtree - split the CPU-pool queue wait out of `tantivy_search` into `waiting_for_cpu_pool` - surface `search_partial_hits_phase` to have all leaves as children
guilload
reviewed
Jul 21, 2026
| split_id = split.split_id, | ||
| num_docs = split.num_docs | ||
| ); | ||
| let wait_span = info_span!(parent: &split_span, "waiting_for_leaf_search_split_semaphore"); |
Member
There was a problem hiding this comment.
Suggested change
| let wait_span = info_span!(parent: &split_span, "waiting_for_leaf_search_split_semaphore"); | |
| let wait_span = info_span!(parent: &split_span, "acquire_leaf_split_search_permit"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restructures search spans so a distributed search forms one coherent tree instead of fragmented, collinear siblings:
multi_index_leaf_searchplan_splits_for_root_search,list_relevant_splits,fetch_docs_in_split, and a per-split wrapper (leaf_search_single_split_wrapper) so each split's wait + warmup + tantivy form one subtreetantivy_searchintowaiting_for_cpu_poolsearch_partial_hits_phaseso all leaves group under one node