search: add query_ast, counts, and warmup byte span attributes#6588
Draft
loutPhilipps wants to merge 1 commit into
Draft
search: add query_ast, counts, and warmup byte span attributes#6588loutPhilipps wants to merge 1 commit into
loutPhilipps wants to merge 1 commit into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 248f437efe
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Adds query AST, split and doc count, time range to the root_search span attributes, and warmup_mb/downloaded_mb attributes on the warmup span. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
loutPhilipps
force-pushed
the
lout.philipps/span-attributes
branch
from
July 21, 2026 12:46
248f437 to
ecb2499
Compare
loutPhilipps
changed the base branch from
lout.philipps/fragmentation
to
lout.philipps/search-tracing-spans
July 21, 2026 12:47
loutPhilipps
marked this pull request as draft
July 21, 2026 12:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
root_searchspan attributeswarmup_mbanddownloaded_mbas attributes on the warmup span🤖 Generated with Claude Code