fix(storage): restore TLS for opendal GCS backend after 0.55→0.56 bump#6478
Open
fmassot wants to merge 1 commit into
Open
fix(storage): restore TLS for opendal GCS backend after 0.55→0.56 bump#6478fmassot wants to merge 1 commit into
fmassot wants to merge 1 commit into
Conversation
opendal 0.56 moved from reqwest 0.12 to reqwest 0.13. Because quickwit's workspace uses reqwest 0.12, Cargo no longer unifies features across the two separate majors. With `default-features = false`, opendal's reqwest 0.13 had no TLS backend, causing every GCS request to fail with: invalid URL, scheme is not http Explicitly enable `reqwest-rustls-tls` (an opendal default feature) so opendal's reqwest 0.13 is compiled with rustls regardless of the workspace reqwest version. Fixes #6477 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
6 tasks
palkakrzysiek
approved these changes
May 30, 2026
palkakrzysiek
left a comment
palkakrzysiek
left a comment
There was a problem hiding this comment.
Hi @fmassot, yes, this PR fixes the issue. Thanks for opening it.
The worrisome aspect of the issue is that no test caught the problem with connection to GCS after dependency upgrade. Please consider modifying existing tests to use secure connection, I put an example in https://github.com/quickwit-oss/quickwit/pull/6479/changes, it targets this PR branch (fix/gcs-opendal-tls) so feel free to merge if it makes sense to you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOT TO MERGE
PR was opened with Claude without full review.
Summary
opendal 0.56moved its internal HTTP client fromreqwest 0.12toreqwest 0.13(different Cargo semver major)default-features = false, opendal'sreqwest 0.13was compiled without any TLS backend — only thestreamfeaturereqwest 0.12(which hasrustls-tls) and opendal'sreqwest 0.13, so TLS was silently missinghttps://storage.googleapis.comfailed immediately withinvalid URL, scheme is not httpFix: explicitly enable
reqwest-rustls-tlson the opendal workspace declaration. This feature was already in opendal's defaults but was stripped bydefault-features = false.Only GCS is affected — S3 uses the AWS SDK, Azure's
azure_storage_blobssetsenable_reqwest_rustlsdirectly.Regression introduced by #6432. Closes #6477.
Test plan
cargo tree -e features -i reqwest:0.13 -p quickwit-storage --features gcsshowsreqwest feature "rustls"in the outputcargo build -p quickwit-storage --features gcspasses🤖 Generated with Claude Code