fix: declare accurate grafanaDependency for jsx-runtime externalization#206
Merged
Conversation
The plugin externalizes react/jsx-runtime (required for React 19 / Grafana 13 support), so it only loads on Grafana versions that provide that module to plugins: 12.3+ and the backport patches 12.0.10, 12.1.7 and 12.2.5. The previous '>=12' declaration wrongly included versions like 12.0.0, where the config editor fails to render. Flagged by the Grafana plugin review of v0.6.2. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin externalizes
react/jsx-runtime(required for React 19 / Grafana 13 support), so it only loads on Grafana versions that provide that module to plugins: 12.3+ and the backport patches 12.0.10, 12.1.7 and 12.2.5. The previous>=12declaration wrongly included versions like 12.0.0, where the config editor fails to render.Flagged by the Grafana plugin review of v0.6.2.
The new range is the canonical output of
npx @grafana/create-plugin@latest add externalize-jsx-runtime(create-plugin 7.9.0); the webpack externals part of that fixlet was already in place. Verified with plugincheck2 (no new findings) and node-semver resolution against 12.0.0–13.1.0.🤖 Generated with Claude Code