test and fix for issue 902, solution generated by Junie

[david-gibbs-ig]

Submitting this PR to confirm that it builds correctly. My local build environment is not working at all well.

[chrjohn]

Seems like SessionRaceConditionTest is hanging for two hours currently.
Edit: maybe that latch needs a timeout to not hang the complete test suite.

[david-gibbs-ig]

@chrjohn Are all these errors related to the change ?

Caused by: java.security.cert.CertPathValidatorException: signature check failed
at java.base/sun.security.provider.certpath.PKIXMasterCertPathValidator.validate(PKIXMasterCertPathValidator.java:135)
at java.base/sun.security.provider.certpath.PKIXCertPathValidator.validate(PKIXCertPathValidator.java:224)
at java.base/sun.security.provider.certpath.PKIXCertPathValidator.validate(PKIXCertPathValidator.java:144)
at java.base/sun.security.provider.certpath.PKIXCertPathValidator.engineValidate(PKIXCertPathValidator.java:83)
at java.base/java.security.cert.CertPathValidator.validate(CertPathValidator.java:309)
at java.base/sun.security.validator.PKIXValidator.doValidate(PKIXValidator.java:313)
... 20 more

[david-gibbs-ig]

Yes I see [INFO] Running quickfix.SessionRaceConditionTest ... working on getting my local dev environment working. From: Christoph John ***@***.***> Sent: Monday, March 9, 2026 5:52 PM To: quickfix-j/quickfixj ***@***.***> Cc: David Gibbs ***@***.***>; Author ***@***.***> Subject: Re: [quickfix-j/quickfixj] test and fix for issue 902, solution generated by Junie (PR #1158) [EXTERNAL] This message originated outside of NADEX. [Image removed by sender.]chrjohn left a comment (quickfix-j/quickfixj#1158)<#1158 (comment)> Seems like SessionRaceConditionTest is hanging for two hours currently. - Reply to this email directly, view it on GitHub<#1158 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHCIBNSBUKL255LF7NUFD4T4P4ACRAVCNFSM6AAAAACWMAQDJKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DAMRVGY3DGMRTGU>. You are receiving this because you authored the thread.Message ID: ***@***.***>

…

________________________________ This electronic mail message and any attachments may contain confidential and/or privileged information that is only intended for use by, North American Derivatives Exchange, Inc. ("Nadex") or third-parties to whom it is directed. The contents of this electronic mail message are not to be copied, modified, published, transmitted, distributed, performed, displayed, or sold in any way. If you are not the addressee, you are prohibited from disclosing, copying, distributing or taking any action based on the contents of this message. If you have received this message by mistake, please contact the sender immediately. All emails sent to or from the Nadex corporate email system may be retained, monitored and/or reviewed by Nadex personnel. Nadex is located at 200 West Jackson Boulevard, Suite 1400, Chicago, IL 60606. Nadex is subject to U.S. regulatory oversight by the CFTC. Futures, options and swaps trading involves risk and may not be appropriate for all investors. The contents herein are not a solicitation, recommendation or offer to buy or sell any particular financial instrument listed on Nadex or elsewhere.

[david-gibbs-ig]

@chrjohn The test can provoke the race condition now.

[INFO] Running quickfix.SessionRaceConditionTest <20260311-14:35:00, FIX.4.4:SENDER->TARGET, event> (Session FIX.4.4:SENDER->TARGET schedule is null) Mar 11, 2026 2:35:00 PM quickfix.UnitTestApplication toAdmin INFO: to admin [FIX.4.4:SENDER->TARGET] 8=FIX.4.4�9=55�35=0�34=1�49=SENDER�52=20260311-14:35:00.607�56=TARGET�10=087� Mar 11, 2026 2:35:00 PM quickfix.UnitTestApplication fromAdmin INFO: from admin [FIX.4.4:SENDER->TARGET] 8=FIX.4.4�9=73�35=A�34=1�49=TARGET�52=20260311-14:35:00.606�56=SENDER�98=0�108=30�141=Y�10=173� <20260311-14:35:00, FIX.4.4:SENDER->TARGET, event> (Created session: FIX.4.4:SENDER->TARGET) [DEBUG_LOG] Attempting to send heartbeats during logon reset delay <20260311-14:35:00, FIX.4.4:SENDER->TARGET, event> (Logon contains ResetSeqNumFlag=Y, resetting sequence numbers to 1) Mar 11, 2026 2:35:01 PM quickfix.UnitTestApplication toAdmin <20260311-14:35:01, FIX.4.4:SENDER->TARGET, event> (Received logon) INFO: to admin [FIX.4.4:SENDER->TARGET] 8=FIX.4.4�9=55�35=0�34=1�49=SENDER�52=20260311-14:35:01.608�56=TARGET�10=089� Mar 11, 2026 2:35:01 PM quickfix.UnitTestApplication toAdmin INFO: to admin [FIX.4.4:SENDER->TARGET] 8=FIX.4.4�9=73�35=A�34=2�49=SENDER�52=20260311-14:35:01.608�56=TARGET�98=0�108=30�141=Y�10=177� <20260311-14:35:01, FIX.4.4:SENDER->TARGET, event> (Responding to Logon request) <20260311-14:35:01, FIX.4.4:SENDER->TARGET, outgoing> (8=FIX.4.4�9=73�35=A�34=2�49=SENDER�52=20260311-14:35:01.608�56=TARGET�98=0�108=30�141=Y�10=177�) Error: Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.021 s <<< FAILURE! -- in quickfix.SessionRaceConditionTest Error: quickfix.SessionRaceConditionTest.testLogonResetRaceCondition -- Time elapsed: 1.018 s <<< FAILURE! java.lang.AssertionError: Outbound Logon should have sequence number 1 when ResetSeqNumFlag=Y expected:<1> but was:<2> at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.failNotEquals(Assert.java:835) at org.junit.Assert.assertEquals(Assert.java:647) at quickfix.SessionRaceConditionTest.testLogonResetRaceCondition(SessionRaceConditionTest.java:141) at java.lang.reflect.Method.invoke(Method.java:498)

[david-gibbs-ig]

@chrjohn I removed the code that did not resolve the bug. Maybe the issue may be solved by synchronization in SessionState, as per its current implementation or perhaps a refactoring with re entrant lock would be better in this class.

Session state class says "The log and message store implementation must be thread safe.", but they are not thread safe. The implementation seems to rely on the Session class.

public void reset() {
        synchronized (lock) {
            try {
                messageStore.reset();
            } catch (IOException e) {
                throw new RuntimeError(e);
            }
        }
  }