Conversation
quickfixj-core/src/main/java/quickfix/mina/SessionConnector.java
Outdated
Show resolved
Hide resolved
|
@the-thing thank you, great addition to the test suite. |
|
@chrjohn I think I have seen this write error when using HTTP proxy (close exception or something). |
|
Which write error? #1143 ?? |
|
Yes, that's the one. I think I have seen it when I was running the new tests locally. Maybe this could something be used for testing? |
|
You mean use the http proxy to provoke the WriteToClosedSessionException? Do you think #1143 is sensible? |
Yes. Mostly for manual testing and debugging the problem, but maybe there can be some changes to capture exceptions for unit test cases to verify if this happens. Needs investigating.
It does look okish, but hold on for now. I might look at this is the upcoming days / weeks (not critical right?). Also |
|
No need to rush, take your time. Thanks in advance!
100% agree. |
Changes
Initially I wanted to open a follow up PR that adds support for explicit proxy auth method for proxy servers that do not support response challenge, but
https://datatracker.ietf.org/doc/html/rfc7235#section-2.1