feat: unadvertised --uninstall mode for skill office - #237
Closed
quickbeard wants to merge 1 commit into
Closed
Conversation
codevhub skill office --uninstall fetches the published per-OS uninstall script (codev-office-<os>-uninstall.sh|ps1) and runs it - no bundle download. --yes / --skills-only / --purge-downloads pass through to the uninstaller; install flags are rejected in uninstall mode and vice versa, so nothing is silently forwarded to a script that would choke on it. Deliberately absent from OFFICE_USAGE and codevhub help. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #236 (same files; retargets to main automatically when it merges).
Adds
codevhub skill office --uninstall: fetches the published per-OS uninstall script (codev-office-<os>-uninstall.sh|ps1, always refetched like the setup script) and runs it from the download dir — no bundle download in this mode.--yes,--skills-only, and--purge-downloadspass through to the uninstaller (-Yes/-SkillsOnly/-PurgeDownloadson Windows); without--yesthe uninstaller's own confirmation prompt works since the spawner inherits stdio.--download-onlyand cross-platform--platformbehave as in install mode (stage the script, print the manual command).Deliberately unadvertised: none of the new flags appear in
OFFICE_USAGEorcodevhub help— discoverable from source only, per the repo's escape-hatch convention. Guardrails follow the strict-parse rule: install flags combined with--uninstall(and uninstall passthroughs without it) error loudly instead of being silently forwarded to a script that would reject them.Test plan
uninstallerArgsfor both shell styles, and an end-to-end run asserting only the uninstall script is fetched (bundle untouched) and spawned with the passthroughscodevhub skill office --uninstall --skills-onlyagainst the bucket once the uninstall scripts are uploaded🤖 Generated with Claude Code