Gemma4#966
Draft
tchawada wants to merge 22 commits into
Draft
Conversation
Contributor
|
@tchawada can you please resolve the conflicts and update the PR. |
quic-hemagnih
requested changes
May 12, 2026
Contributor
quic-hemagnih
left a comment
quic-hemagnih
left a comment
There was a problem hiding this comment.
Can we add the test case in the CI
tchawada
force-pushed
the
gemma4
branch
2 times, most recently
from
ebd6845 to
4e97579
Compare
| skip_model_io=True, | ||
| **compiler_kwargs, | ||
| ) | ||
| breakpoint() |
quic-hemagnih
requested changes
May 25, 2026
| for i in range(num_chunks): | ||
| chunk_inputs["input_ids"] = lang_inputs["input_ids"][:, i * PREFILL_SEQ_LEN : (i + 1) * PREFILL_SEQ_LEN] | ||
| chunk_inputs["position_ids"] = lang_inputs["position_ids"][..., i * PREFILL_SEQ_LEN : (i + 1) * PREFILL_SEQ_LEN] | ||
| breakpoint() |
Contributor
There was a problem hiding this comment.
remove breakpoints @qcdipankar Please check and remove all the breakpoints
quic-hemagnih
requested changes
May 26, 2026
qcdipankar
requested changes
May 26, 2026
| return self.model.config.__dict__ | ||
|
|
||
|
|
||
| class _QEffAutoModelForImageTextToTextLanguageOnlyCompat: |
Contributor
There was a problem hiding this comment.
@tchawada why are we making a new AutoModel for lang part in text can't we handle using the same conditional generation as that of other VLM's?
Contributor
Author
There was a problem hiding this comment.
I am changing this
| # and vision_onnx_path is None | ||
| # ) | ||
| # need_export_lang = self.lang_model.onnx_path is None and lang_onnx_path is None | ||
| # if need_export_vision or need_export_lang: |
Contributor
There was a problem hiding this comment.
this patch is different and changes the variables and the meaning of their usage for diss mode can we go back to mainline variables
| if k | ||
| in {"pixel_values", "image_masks", "image_input_idx", "valid_idx", "aspect_ratio_ids", "aspect_ratio_mask"} | ||
| in { | ||
| "pixel_values", |
Contributor
There was a problem hiding this comment.
why is image position ids required here?
Contributor
Author
There was a problem hiding this comment.
Without them, the output is not meaningful
|
|
||
| target_dtype = getattr(self.model.config, "torch_dtype", torch.float32) | ||
| convert_to_fp16 = CUSTOM_IO_DTYPE_MAP[target_dtype] == "float16" | ||
| print(convert_to_fp16) |
Contributor
There was a problem hiding this comment.
remove the print from here
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
End to end pipeline for gemma4