Resolve GlobalID::Locator.locate missing argument warning#435
Open
salimepoint wants to merge 1 commit intoque-rb:masterfrom
Open
Resolve GlobalID::Locator.locate missing argument warning#435salimepoint wants to merge 1 commit intoque-rb:masterfrom
salimepoint wants to merge 1 commit intoque-rb:masterfrom
Conversation
Add in an (unused) options arg for the TestLocator locate method to resolve the following deprecation warning thrown by Rails 7.1 when running the test suite:
DEPRECATION WARNING: It seems your locator is defining the `locate` method only with one argument. Please make sure your locator is receiving the options argument as well, like `locate(gid, options = {})`. (called from run at /work/lib/que/active_job/extensions.rb:138)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add in an (unused)
optionsarg for theTestLocator.locatemethod to resolve the following deprecation warning thrown by Rails 7.1 when running the test suite:Another option would be
but as the earliest versions of the base
GlobalID::Locator.locatemethod have theoptions = {}second argument I think what's in the PR should be fine regardless of the underlying Rails version?