Add more descriptive error to file loading#433
Open
TheBlackArroVV wants to merge 2 commits intoque-rb:masterfrom
Open
Add more descriptive error to file loading#433TheBlackArroVV wants to merge 2 commits intoque-rb:masterfrom
TheBlackArroVV wants to merge 2 commits intoque-rb:masterfrom
Conversation
Member
Author
|
Hi, @ZimbiX, |
Member
|
Something like: args.each do |file|
require whatever_method_returns_a_full_file_path(file)
endThat way, all forms of relative file path can be accepted. Then if an exception is raised due to the given file not existing, that should be pretty easy to understand already, I'd think. Edit: Looks like |
Author
|
@ZimbiX, got it, makes sense |
Author
|
Hey, @ZimbiX, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After trying to run it locally I found out, that an original error about the unavailability to run a file is not descriptive. So, I decided to add an error to make it more obvious.