claircore: change Package.Kind type and add new values#1781
Open
claircore: change Package.Kind type and add new values#1781
Package.Kind type and add new values#1781Conversation
hdonnay
force-pushed
the
feature/not-affected/package-kind
branch
2 times, most recently
from
fe5217b to
e8b5727
Compare
BradLugo
reviewed
Mar 26, 2026
Comment on lines
+80
to
+85
| // An "ancestry" package is used to refer to a container layer and all | ||
| // previous layers in an image. | ||
| // | ||
| // Conceptually, an "ancestry" package is a higher type that describes the | ||
| // container image rather than the contents. | ||
| PackageAncestry // ancestry |
Contributor
There was a problem hiding this comment.
I'm not sure why, but this seems a bit unclear to me. Did you have some other ideas about this name? Or maybe we should explain why this value is important.
Member
Author
There was a problem hiding this comment.
Suggested change
| // An "ancestry" package is used to refer to a container layer and all | |
| // previous layers in an image. | |
| // | |
| // Conceptually, an "ancestry" package is a higher type that describes the | |
| // container image rather than the contents. | |
| PackageAncestry // ancestry | |
| // An "ancestry" package is used to refer to a container layer and all | |
| // previous layers (a layer and its ancestors) in an image. | |
| // | |
| // Conceptually, an "ancestry" package is a higher type that describes the | |
| // container image rather than the contents. | |
| PackageAncestry // ancestry |
This was largely an automated rewrite, but does touch a lot of files. See-also: https://issues.redhat.com/browse/CLAIRDEV-85 Change-Id: I6ed030878dcccb1a5d0c437f2b480e9f0bea80fd Signed-off-by: Hank Donnay <hdonnay@redhat.com>
hdonnay
force-pushed
the
feature/not-affected/package-kind
branch
from
e8b5727 to
853067b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was largely an automated rewrite, but does touch a lot of files.
See-also: https://issues.redhat.com/browse/CLAIRDEV-85
Change-Id: I6ed030878dcccb1a5d0c437f2b480e9f0bea80fd
Signed-off-by: Hank Donnay hdonnay@redhat.com