Skip to content

Download table: put the full checksum in the DOM, truncate it with CSS #2139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cwickham wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Download table: put the full checksum in the DOM, truncate it with CSS #2139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 10 additions & 15 deletions docs/download/_download.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,6 @@

}

window.tippy("a.checksum[data-tippy-content]", {
interactive: true,
placement: "top-end",
maxWidth: "none",
});
})
.catch((err) => {
console.log(err);
Expand Down Expand Up @@ -217,7 +212,15 @@
}

const table = createTable();
createHeadingRow(table, ["Platform", "Download", "Size", "SHA-256"]);
// Link the header to the release's checksums.txt: the full values stay
// reachable even where narrow screens truncate the hashes (WCAG 1.4.10).
const checksumsAsset = assets.find((asset) =>
asset.name.endsWith("-checksums.txt")
);
const shaHeading = checksumsAsset
? `<a href="${checksumsAsset.download_url}">SHA-256</a>`
: "SHA-256";
createHeadingRow(table, ["Platform", "Download", "Size", shaHeading]);

const tbody = table.createTBody();
assets.forEach((asset) => {
Expand All @@ -228,11 +231,6 @@
}

downloadTableContainer.append(table);
window.tippy(".checksum[data-tippy-content]", {
interactive: true,
placement: "top-end",
maxWidth: "none",
});
}

function createTable() {
Expand Down Expand Up @@ -287,12 +285,9 @@

const checksumCell = row.insertCell(i++);
if (asset.checksum) {
const checkSumSlice = asset.checksum.slice(0, 7);

const checksumEl = window.document.createElement("div");
checksumEl.className = "checksum font-monospace";
checksumEl.setAttribute("data-tippy-content", asset.checksum);
checksumEl.innerText = checkSumSlice;
checksumEl.innerText = asset.checksum;
checksumCell.appendChild(checksumEl);
}
}
Expand Down
9 changes: 7 additions & 2 deletions styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,16 @@ body.quarto-dark #quarto-header {
margin-bottom: 0;
}

/* The cell holds the full hash; only the rendering truncates (ellipsis).
Screen readers, copying, and find-in-page all see the complete value,
and the header links to checksums.txt for the full values. */
.download-table .checksum {
color: var(--bs-primary);
font-size: .775em;
cursor: pointer;
padding-top: 4px;
max-width: 9ch;
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
}

.download-button {
Expand Down