Fix "access violation" failures that have appeared in new windows builds by disabling compiler optimization on windows#1077
Merged
Merged
Conversation
- Similarly fix `end="auto"` - Also improve `stimflow.Flow.__repr__` not returning a parseable result
/O2 to /O0
/O2 to /O0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root cause was a compiler autovectorization bug. Turning off optimizations will hurt performance but at least make the code not totally broken.
Reproduction of the bug in a simpler instance:
Go to godbolt, paste the above code, compile it with the compiler
x64 msvc v19.51 VS18.6and flags/O2and run it and it will printt=8589934594instead oft=2.Fixes #1078