Speed up hamiltonian_simulation_by_gqsp_test and mark slow tests#1878
Open
mpharrigan wants to merge 4 commits into
Open
Speed up hamiltonian_simulation_by_gqsp_test and mark slow tests#1878mpharrigan wants to merge 4 commits into
mpharrigan wants to merge 4 commits into
Conversation
mpharrigan
added
the
devops
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces Cirq-based unitary calculation with bloq_to_dense in the Hamiltonian simulation GQSP tests, removing Cirq imports and associated performance-related TODO comments. Additionally, it marks slow-running test cases with pytest.mark.slow in both prepare_uniform_superposition_test.py and _roudtrip_test.py. I have no feedback to provide.
Collaborator
Author
|
Marginal improvement on the CI, but on my workstation (with parallelization) it goes from 2:52 to to 1:22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By using
full_flatten=False, we avoid contracting a tensor network with hundreds of tensors by short circuiting Controlled as well as SU2Rotation. Per #1336 #1763 -- flattening the tensor network took secondsI also ran through
--durations=10onpytest-quickrunning serially and marked two tests as "slow"