Automatically create binaries when creating releases#11
Open
Leonidas-from-XIV wants to merge 2 commits intoquantifyearth:mainfrom
Open
Automatically create binaries when creating releases#11Leonidas-from-XIV wants to merge 2 commits intoquantifyearth:mainfrom
Leonidas-from-XIV wants to merge 2 commits intoquantifyearth:mainfrom
Conversation
When a tag is pushed, a github action will build the project using dune package management and release the binaries under the tag on github. Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an extension of @gridbugs' work in #7 (and contains it as first commit), updating it with the current state of Dune package management.
dune-release) it triggers the release workflow which will use Dune package management to build the project on macOS (AMD64 & ARM64), Ubuntu (AMD64) and Alpine (AMD64, static) using the Github runners and will upload the results to the release that was created. This takes in my testing about 5 minutes on Linux, 10 minutes on macOS ARM64 and 15 minutes on AMD64. Thus the release binaries appear on the release within about 20 minutes.As for demonstration, in our fork of the project I have created a release which has the 2 source archives automatically created by GitHub. Then the release also contains 4 tarballs which were uploaded by the automatically-triggered action run which can be inspected and debugged.
The repository continues to be usable with OPAM as well as without (the recently released Dune 3.22 has a
--pkg=disabledflag to disable using package management); packaging for OPAM should also work without issue ascontainer-image.opamusesdune build -pwhich also disables package management even in the presence of lock directories.Thanks to @gridbugs who did the majority of the initial work, @Alizter who helped me debug issues with static builds that segfaulted and @Sudha247 who helped to review internally.
Closes #7.