refactor: Extract index file handling into helper function#42
Merged
lightninglu10 merged 2 commits intomainfrom Nov 29, 2025
Merged
refactor: Extract index file handling into helper function#42lightninglu10 merged 2 commits intomainfrom
lightninglu10 merged 2 commits intomainfrom
Conversation
Extract duplicate `/index` handling logic into a private helper method `addModuleMapEntry` to avoid code duplication. The pattern of adding both the regular entry and the `/index` variant to the module map appeared twice in the webpack plugin and is now consolidated into a single reusable method. This improves maintainability and reduces the risk of inconsistencies between the two code paths. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
❇️ CodePress Review Summary
👋 Hey team,
Overall the changes look great! No specific issues found.
Here's the quick rundown:
✅ Decision: APPROVE
The change is a straightforward refactor that maintains existing behavior. No clear blocking correctness, security, or performance issues are evident; potential aliasing concerns are non-blocking.
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/indexhandling logic into a reusable helper methodaddModuleMapEntrysrc/webpack-plugin.tswhere the same pattern appeared twiceChanges
The pattern for handling index files (adding both the regular entry and a variant without the
/indexsuffix) was duplicated in two places:Created a private helper method that:
moduleMap/indexsuffix for index filesTest Plan
npm run build)npm test)🤖 Generated with Claude Code