Fix: preserve parentheses around output section VMA#1043
Merged
quic-seaswara merged 1 commit intoqualcomm:mainfrom Apr 12, 2026
Merged
Fix: preserve parentheses around output section VMA#1043quic-seaswara merged 1 commit intoqualcomm:mainfrom
quic-seaswara merged 1 commit intoqualcomm:mainfrom
Conversation
quic-seaswara
approved these changes
Apr 10, 2026
When a linker script has parentheses around the output section VMA:
.text (0x1000) : { *(.text*) }
Fix this by calling setParen() on the VMA expression when parentheses
are detected during parsing in readOutputSectDescPrologue().
Signed-off-by: deepakshirkem <deepakshirke509@gmail.com>
d657930 to
496f8e8
Compare
Contributor
Author
|
Hi @quic-seaswara, Apologies for the build failure. The issue was misleading indentation Could you please re-run the pipeline? Thank you ::)) |
quic-seaswara
approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #338
Fix
Call
setParen()on the VMA expression when parentheses are detected:Testing
Added a lit test that verifies parentheses are preserved in the plugin output.