Skip to content

Update qcom-preflight-checks to latest.yml#86

Open
Sandhya1236 wants to merge 1 commit intoqualcomm-linux:video.qclinux.0.0from
Sandhya1236:Update-Qualcomm-Preflight-Checks-with-latest-1
Open

Update qcom-preflight-checks to latest.yml#86
Sandhya1236 wants to merge 1 commit intoqualcomm-linux:video.qclinux.0.0from
Sandhya1236:Update-Qualcomm-Preflight-Checks-with-latest-1

Conversation

@Sandhya1236
Copy link
Copy Markdown

Running untrusted code on the pull_request_target trigger may lead to security vulnerabilities. These vulnerabilities include cache poisoning and granting unintended access to write privileges or secrets.

https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#pull_request_target

We should update all usage of pull_request_target in all workflow files and also update qualcomm-preflight-check to the latest.

pull_request_target can be a security vulnerability and should be avoided and also aligned with latest pre-flight check workflow.

Signed-off-by: Sandhya Adavikolanu <sadaviko@qti.qualcomm.com>
@Sandhya1236 Sandhya1236 force-pushed the Update-Qualcomm-Preflight-Checks-with-latest-1 branch from f57ce66 to d4e3ae5 Compare April 1, 2026 06:13
@Sandhya1236
Copy link
Copy Markdown
Author

CI failure is expected on fork PRs with pull_request

This job is failing at actions/checkout (before QC Preflight runs). The workflow is attempting to fetch the PR head repo (fork) and checkout fails with “Repository not found” / exit code 128 because the workflow token can’t access the fork in our internal/private setup.

This matches OSDO guidance in “OSS Ops Guidance:

https://github.qualcomm.com/OSDO/osdo.github.qualcomm.com/pull/212/files

Prefer splitting untrusted and trusted workflows:
Use pull_request for PR builds/tests (no secrets, read-only).
Move secret-dependent/privileged steps to trusted triggers (e.g. push to protected branches, workflow_dispatch, etc.).
Guiding principle: “Untrusted code and privileged access must never coexist in the same workflow.”
So the failure is due to GitHub’s fork PR permissions model after moving away from pull_request_target, not due to the changes in this PR.

Copy link
Copy Markdown

@njjetha njjetha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@njjetha njjetha requested a review from vgarodia April 1, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants