qcom-multimedia-image: add bbappend from meta-qcom-distro#1864
qcom-multimedia-image: add bbappend from meta-qcom-distro#1864quaresmajose wants to merge 2 commits intoqualcomm-linux:masterfrom
Conversation
qcom-multimedia-image is expected to contain only the open-source software (except for the components to be executed on the non-main cores, e.g on Hexagon DSP). Use INCOMPATIBLE_LICENSE to make sure that no closed-source software can get into qcom-multimedia-image. The setting is performed in the bbappend so that it doesn't affect other images which include qcom-multimedia-image.bb (like the qcom-multimedia-proprietary-image). Fixes qualcomm-linux#1762 Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> (cherry picked from commit cc1db67) qualcomm-linux/meta-qcom-distro@cc1db67 Signed-off-by: Jose Quaresma <jose.quaresma@oss.qualcomm.com>
Listing libvulkan-adreno1 in the BAD_RECOMMENDATIONS makes dnf ignore it and thus pull in meta-vulkan-drivers as a virtual-vulkan-icd provider. Drop unnecessary assignment pulling in meta-vulkan-drivers again. Fixes qualcomm-linux#1762 Fixes: cc1db67c0174 ("qcom-multimedia-image: conflict with proprietary software") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> (cherry picked from commit 7add89e) qualcomm-linux/meta-qcom-distro@7add89e Signed-off-by: Jose Quaresma <jose.quaresma@oss.qualcomm.com>
quaresmajose
requested review from
anujm1,
koenkooi,
lumag,
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
Test run workflowTest jobs for commit cf5d97c
All jobs summary
|
Test Results 27 files - 1 27 suites - 1 1h 1m 58s ⏱️ - 1m 48s For more details on these failures, see this check. Results for commit cf5d97c. ± Comparison against base commit 5b44f6c. This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both. |
I understand it helps having it here, but I don't think this should be managed by the BSP layer, as the inclusion or not into whatever image should be a distro decision in the end. |
|
Is on the bsp layer we know which components should be in INCOMPATIBLE_LICENSE_EXCEPTIONS, they are all part of that layer. They are included or excluded from the images by packesgroups defined here in the BSP layer as well. It doesn't make sense for someone to have to add a package blindly in the distro layer INCOMPATIBLE_LICENSE_EXCEPTIONS list in order to successfully execute the CI on the BSP layer. |
lumag
left a comment
lumag
left a comment
There was a problem hiding this comment.
No. All of this is purely a distro configuration and distro decisions.
You are quoting the deficiency of our current CI. It is going to be changed after the 2.0 release. |
Are we going to keep the bbappend in meta-qcom-distro? |
Yes. Please submit a PR for meta-qcom-distro. |
|
Fixed with qualcomm-linux/meta-qcom-distro#257 |
|
I don't understand why we didn't do here the same thing we did in qualcomm-linux/meta-qcom-3rdparty#24. |
4 participants
Moved qcom-multimedia-image.bbappend from qualcomm-linux/meta-qcom-distro#203
When adding restricted content here in the BSP layer, it's necessary to adjust the image as well, so it should be here and not in the distribution layer.
Fixes #1762