packagegroup-rb3gen2: Add BT firmware for QCA61x4 and QCC2072 chips#1490
Conversation
|
RB3 Gen2 doesn't have an M.2 slot, does it? So please describe in the commit message your usecase and why it should be done here. |
Yes, RB3 Gen2 Indus Mezz kit has M.2 slot |
Okay, so if one install Broadcom or Intel M.2 card into that slot, should we also enable correspodning firmware for the RB3 Gen2 kit? |
No, Currently supporting HSP USB and cologne USB are product requirements on Kodiak Indus Mezz so adding firmware for the same. |
If they are requirements for the Industrial Mezzanine, why are you adding those to the main package? |
|
And also, how would anyone guess your requirements from your commit message? |
Agree with you, but didn't find separate package group for Industrial Mezzanine kit so added here. |
|
You can add new package in the same recipe. |
1409250 to
103f446
Compare
Hi @lumag , |
I explicitly wrote, "same recipe". Also, your commit message didn't improve. It tells obvious things, what is included, but doesn't tell why. |
103f446 to
6b77443
Compare
added in the same recipe and updated the commit message. |
lumag
left a comment
There was a problem hiding this comment.
support HSP and cologne over M.2
What are 'HSP and cologne'? What does it mean for anybody outside of the BT team?
6b77443 to
1860fe2
Compare
Thanks, it is valid point, can we replace with WCN names like below ?,which are attachement outside
Thanks, that’s a valid point. To avoid terminology like HSP and Cologne, we can replace them with the actual chip names that are already commonly used across teams. |
| MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += " \ | ||
| packagegroup-rb3gen2-firmware \ | ||
| packagegroup-rb3gen2-hexagon-dsp-binaries \ | ||
| packagegroup-rb3gen2-indus-mezz-bt-firmware \ |
There was a problem hiding this comment.
What is indus-mezz? Industrial Mezzanine? then packagegroup-rb3gen2-industrial-mezzanine-firmware.
The machine config changes should go to a separate commit too.
There was a problem hiding this comment.
Yes,it is Industrial Mezzanine
updated separate commit PR :#1586
There was a problem hiding this comment.
I wrote, separate commits, not separate PRs. I'll close that one, it doesn't build (and this one can't really be tested without it).
There was a problem hiding this comment.
I wrote, separate commits, not separate PRs. I'll close that one, it doesn't build (and this one can't really be tested without it).
sorry, updated with new commit
| ${PN}-indus-mezz-bt-firmware \ | ||
| " | ||
|
|
||
| RRECOMMENDS:${PN}-indus-mezz-bt-firmware = " \ |
There was a problem hiding this comment.
Drop the -bt part. It's a packagegroup for the whole mezzanine.
There was a problem hiding this comment.
sure,dropped in the updated commit
c73ee1a to
a8c8772
Compare
…or M.2 rb3-gen2-industrial-mezzanine has product requirement to support QCA61x4 and QCC2072 over M.2. Including the firmwares ensures proper initialization for both supported M.2 variants - QCA61x4 (HSP over USB): linux-firmware-qca-qca61x4-usb - QCC2072 (Cologne over UART): linux-firmware-qca-qcc2072. Signed-off-by: Janaki Ramaiah Thota <janaki.thota@oss.qualcomm.com>
Including this packagegroup ensures that the required firmware for the Industrial Mezzanine. Signed-off-by: Janaki Ramaiah Thota <janaki.thota@oss.qualcomm.com>
Head branch was pushed to by a user without write access
efa2a89 to
5cdb39f
Compare
|
I have rebased my branch to the latest tip of the master branch. |
Why? Have you been asked to do it? |
Add rb3gen2 supported bluetooth modules firmwares
QCA61x4 module requires
- linux-firmware-qca-qca61x4-usb (Mossel BT firmware over M.2 USB) QCC2072 module requires
- linux-firmware-qca-qcc2072 (Cologne BT firmware over UART)