Skip to content

packagegroup-rb3gen2: Add BT firmware for QCA61x4 and QCC2072 chips#1490

Merged
ricardosalveti merged 2 commits intoqualcomm-linux:masterfrom
quicjathot:include_upstream_fw
Feb 21, 2026
Merged

packagegroup-rb3gen2: Add BT firmware for QCA61x4 and QCC2072 chips#1490
ricardosalveti merged 2 commits intoqualcomm-linux:masterfrom
quicjathot:include_upstream_fw

Conversation

@quicjathot
Copy link
Copy Markdown
Contributor

Add rb3gen2 supported bluetooth modules firmwares

QCA61x4 module requires
- linux-firmware-qca-qca61x4-usb (Mossel BT firmware over M.2 USB) QCC2072 module requires
- linux-firmware-qca-qcc2072 (Cologne BT firmware over UART)

@lumag
Copy link
Copy Markdown
Contributor

lumag commented Feb 5, 2026

RB3 Gen2 doesn't have an M.2 slot, does it? So please describe in the commit message your usecase and why it should be done here.

@quicjathot
Copy link
Copy Markdown
Contributor Author

RB3 Gen2 doesn't have an M.2 slot, does it? So please describe in the commit message your usecase and why it should be done here.

Yes, RB3 Gen2 Indus Mezz kit has M.2 slot
This package group is common for all the RB3 Gen2 variants.

@lumag
Copy link
Copy Markdown
Contributor

lumag commented Feb 6, 2026

RB3 Gen2 doesn't have an M.2 slot, does it? So please describe in the commit message your usecase and why it should be done here.

Yes, RB3 Gen2 Indus Mezz kit has M.2 slot This package group is common for all the RB3 Gen2 variants.

Okay, so if one install Broadcom or Intel M.2 card into that slot, should we also enable correspodning firmware for the RB3 Gen2 kit?

@quicjathot
Copy link
Copy Markdown
Contributor Author

RB3 Gen2 doesn't have an M.2 slot, does it? So please describe in the commit message your usecase and why it should be done here.

Yes, RB3 Gen2 Indus Mezz kit has M.2 slot This package group is common for all the RB3 Gen2 variants.

Okay, so if one install Broadcom or Intel M.2 card into that slot, should we also enable correspodning firmware for the RB3 Gen2 kit?

No, Currently supporting HSP USB and cologne USB are product requirements on Kodiak Indus Mezz so adding firmware for the same.

@lumag
Copy link
Copy Markdown
Contributor

lumag commented Feb 9, 2026

RB3 Gen2 doesn't have an M.2 slot, does it? So please describe in the commit message your usecase and why it should be done here.

Yes, RB3 Gen2 Indus Mezz kit has M.2 slot This package group is common for all the RB3 Gen2 variants.

Okay, so if one install Broadcom or Intel M.2 card into that slot, should we also enable correspodning firmware for the RB3 Gen2 kit?

No, Currently supporting HSP USB and cologne USB are product requirements on Kodiak Indus Mezz so adding firmware for the same.

If they are requirements for the Industrial Mezzanine, why are you adding those to the main package?

@lumag
Copy link
Copy Markdown
Contributor

lumag commented Feb 9, 2026

And also, how would anyone guess your requirements from your commit message?

@quicjathot
Copy link
Copy Markdown
Contributor Author

quicjathot commented Feb 9, 2026

RB3 Gen2 doesn't have an M.2 slot, does it? So please describe in the commit message your usecase and why it should be done here.

Yes, RB3 Gen2 Indus Mezz kit has M.2 slot This package group is common for all the RB3 Gen2 variants.

Okay, so if one install Broadcom or Intel M.2 card into that slot, should we also enable correspodning firmware for the RB3 Gen2 kit?

No, Currently supporting HSP USB and cologne USB are product requirements on Kodiak Indus Mezz so adding firmware for the same.

If they are requirements for the Industrial Mezzanine, why are you adding those to the main package?

RB3 Gen2 doesn't have an M.2 slot, does it? So please describe in the commit message your usecase and why it should be done here.

Yes, RB3 Gen2 Indus Mezz kit has M.2 slot This package group is common for all the RB3 Gen2 variants.

Okay, so if one install Broadcom or Intel M.2 card into that slot, should we also enable correspodning firmware for the RB3 Gen2 kit?

No, Currently supporting HSP USB and cologne USB are product requirements on Kodiak Indus Mezz so adding firmware for the same.

If they are requirements for the Industrial Mezzanine, why are you adding those to the main package?

RB3 Gen2 doesn't have an M.2 slot, does it? So please describe in the commit message your usecase and why it should be done here.

Yes, RB3 Gen2 Indus Mezz kit has M.2 slot This package group is common for all the RB3 Gen2 variants.

Okay, so if one install Broadcom or Intel M.2 card into that slot, should we also enable correspodning firmware for the RB3 Gen2 kit?

No, Currently supporting HSP USB and cologne USB are product requirements on Kodiak Indus Mezz so adding firmware for the same.

If they are requirements for the Industrial Mezzanine, why are you adding those to the main package?

Agree with you, but didn't find separate package group for Industrial Mezzanine kit so added here.
This packagegroup-rb3gen2.bb is common for all rb3gen2 variant, here Industrial Mezzanine kit is one of the variant
and also one common initramfs-firmware-rb3gen2-image for all rb3gen2 variants

@quicjathot
Copy link
Copy Markdown
Contributor Author

And also, how would anyone guess your requirements from your commit message?

And also, how would anyone guess your requirements from your commit message?
Sure, will update message with more info

@lumag
Copy link
Copy Markdown
Contributor

lumag commented Feb 9, 2026

Agree with you, but didn't find separate package group for Industrial Mezzanine kit so added here.

You can add new package in the same recipe.

@quicjathot
Copy link
Copy Markdown
Contributor Author

Agree with you, but didn't find separate package group for Industrial Mezzanine kit so added here.

You can add new package in the same recipe.

Hi @lumag ,
As suggested added new recipe and updated the new patch set please review.

@lumag
Copy link
Copy Markdown
Contributor

lumag commented Feb 11, 2026

Agree with you, but didn't find separate package group for Industrial Mezzanine kit so added here.

You can add new package in the same recipe.

Hi @lumag , As suggested added new recipe and updated the new patch set please review.

I explicitly wrote, "same recipe". Also, your commit message didn't improve. It tells obvious things, what is included, but doesn't tell why.

@quicjathot
Copy link
Copy Markdown
Contributor Author

Agree with you, but didn't find separate package group for Industrial Mezzanine kit so added here.

You can add new package in the same recipe.

Hi @lumag , As suggested added new recipe and updated the new patch set please review.

I explicitly wrote, "same recipe". Also, your commit message didn't improve. It tells obvious things, what is included, but doesn't tell why.

added in the same recipe and updated the commit message.

Copy link
Copy Markdown
Contributor

@lumag lumag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

support HSP and cologne over M.2

What are 'HSP and cologne'? What does it mean for anybody outside of the BT team?

@quicjathot
Copy link
Copy Markdown
Contributor Author

quicjathot commented Feb 17, 2026

support HSP and cologne over M.2

What are 'HSP and cologne'? What does it mean for anybody outside of the BT team?

Thanks, it is valid point, can we replace with WCN names like below ?,which are attachement outside
"rb3-gen2-indus-mezz has product requirement to support QCA61x4 and QCC2072 over M.2"

support HSP and cologne over M.2

What are 'HSP and cologne'? What does it mean for anybody outside of the BT team?

Thanks, that’s a valid point. To avoid terminology like HSP and Cologne, we can replace them with the actual chip names that are already commonly used across teams.
rb3-gen2-indus-mezz has product requirement to support QCA61x4 and QCC2072 over M.2
I updated the commit message accordingly to make it clearer for non‑BT teams.

Comment thread conf/machine/rb3gen2-core-kit.conf Outdated
MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += " \
packagegroup-rb3gen2-firmware \
packagegroup-rb3gen2-hexagon-dsp-binaries \
packagegroup-rb3gen2-indus-mezz-bt-firmware \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is indus-mezz? Industrial Mezzanine? then packagegroup-rb3gen2-industrial-mezzanine-firmware.
The machine config changes should go to a separate commit too.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes,it is Industrial Mezzanine
updated separate commit PR :#1586

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote, separate commits, not separate PRs. I'll close that one, it doesn't build (and this one can't really be tested without it).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote, separate commits, not separate PRs. I'll close that one, it doesn't build (and this one can't really be tested without it).

sorry, updated with new commit

${PN}-indus-mezz-bt-firmware \
"

RRECOMMENDS:${PN}-indus-mezz-bt-firmware = " \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop the -bt part. It's a packagegroup for the whole mezzanine.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure,dropped in the updated commit

@quicjathot quicjathot force-pushed the include_upstream_fw branch 2 times, most recently from c73ee1a to a8c8772 Compare February 17, 2026 17:47
@quic-mohamull quic-mohamull requested a review from lumag February 19, 2026 02:29
@lumag lumag enabled auto-merge February 19, 2026 13:10
…or M.2

rb3-gen2-industrial-mezzanine has product requirement to support QCA61x4
and QCC2072 over M.2. Including the firmwares ensures proper initialization
for both supported M.2 variants
  - QCA61x4 (HSP over USB): linux-firmware-qca-qca61x4-usb
  - QCC2072 (Cologne over UART): linux-firmware-qca-qcc2072.

Signed-off-by: Janaki Ramaiah Thota <janaki.thota@oss.qualcomm.com>
Including this packagegroup ensures that the required firmware for the
Industrial Mezzanine.

Signed-off-by: Janaki Ramaiah Thota <janaki.thota@oss.qualcomm.com>
auto-merge was automatically disabled February 20, 2026 06:41

Head branch was pushed to by a user without write access

@quicjathot
Copy link
Copy Markdown
Contributor Author

I have rebased my branch to the latest tip of the master branch.

@lumag
Copy link
Copy Markdown
Contributor

lumag commented Feb 20, 2026

I have rebased my branch to the latest tip of the master branch.

Why? Have you been asked to do it?

@ricardosalveti ricardosalveti merged commit 5fb1713 into qualcomm-linux:master Feb 21, 2026
168 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants