Support builds for both UFS and NVMe on IQ-X7181 by shoudil · Pull Request #1453 · qualcomm-linux/meta-qcom

shoudil · 2026-01-29T09:58:47Z

On Hamoa IoT EVK device, both UFS and NVMe storage are supported. To generate both UFS and NVMe builds together in image folder, Add flags to control the partition bins/xml files deployment for both NVMe and UFS in image folder. These partition files under subfolder can be combined with HLOS images in root folder to construct flashable builds as per need.

lumag

Describe why the change is necessary. I would have expected that the root folder contains partition and image files for the main storage (e.g. NVMe in this case).

test-reporting-app · 2026-01-29T14:29:54Z

Test Results

28 files - 18 28 suites - 139 1h 45m 7s ⏱️ - 27m 42s
13 tests - 34 9 ✅ - 37 0 💤 ±0 4 ❌ +3
245 runs - 1 344 241 ✅ - 1 339 0 💤 - 7 4 ❌ +2

For more details on these failures, see this check.

Results for commit 55c9703. ± Comparison against base commit d7f8538.

This pull request removes 36 and adds 2 tests. Note that renamed tests count towards both.

0_BT_FW_KMD_Service ‑ BT_FW_KMD_Service
0_hotplug ‑ hotplug
10_AudioRecord ‑ AudioRecord
11_DSP_AudioPD ‑ DSP_AudioPD
11_Ethernet ‑ Ethernet
12_DSP_AudioPD ‑ DSP_AudioPD
1_BT_SCAN ‑ BT_SCAN
1_CPUFreq_Validation ‑ CPUFreq_Validation
2_Interrupts ‑ Interrupts
3_cdsp_remoteproc ‑ cdsp_remoteproc
…

lava ‑ auto-login-action
lava ‑ minimal-boot

♻️ This comment has been updated with latest results.

shoudil · 2026-01-30T03:16:41Z

Describe why the change is necessary. I would have expected that the root folder contains partition and image files for the main storage (e.g. NVMe in this case).

I will rebase this PR on #1422, in which UFS build is supported by default.

lumag · 2026-01-30T04:27:21Z

@@ -18,6 +18,7 @@ QCOM_DTB_FILE ?= "dtb.bin"
 QCOM_BOOT_FILES_SUBDIR ?= ""


Instructions to create NVMe flat build:

No need to. Please instead describe, why this is necessary. Your commits should start with the description of the issue or the problem.

And your commit message is still not fixed.

Updated in a07975d

lumag · 2026-01-30T04:28:01Z

 QCOM_CDT_FILE = "IQ_X_EVK_CDT"
 QCOM_BOOT_FILES_SUBDIR = "iq-x7181"
 QCOM_PARTITION_FILES_SUBDIR ?= "partitions/iq-x7181-evk/ufs"
+QCOM_PARTITION_FILES_SUBDIR_NVME ?= "partitions/iq-x7181-evk/nvme"


Likewise. I can see your changes. Why are they performed?

Hi @lumag,

We want to support both UFS and NVMe build together in image folder, like this:

It should be explained in the commit messages.

UFS: HLOS flat build for UFS in root folder NVMe: partition bins/xml placed under nvme subfolder, which can be combined with HLOS image in root folder to construct a flat build for NVMe. Spinor: in spinor subfolder, included non-hlos images and spinor part bins/xml.

What is the reason for asymmetry: UFS is the root folder, while NVMe is in the subfolder?

As per current design, only one build could be supported in root folder, here we support UFS by default. For nmve subfolder we put the nvme partition files (part of the NVMe build to be constructed). We don't need ufs subfolder to place ufs partition files as they are present in root folder already.

This create asymmetry. From my PoV we should either have two (three, four, etc.) subfolders, one for each storage type, or have multiple machines (I'm not sure about this one, but older machines were not using SPI NOR when booting from UFS).

Having subfolder for both cases here would probably make more sense, if the artifacts are indeed common to both.

Updated in commit d63ba16 9339632

Please update the commit message, explaining the reasons for the change rather than the patch itself.

Updated in 55c9703

github-actions · 2026-01-30T07:45:59Z

Test run workflow

Test jobs for commit `b0b7e75`

Test	dragonboard-410c	dragonboard-820c	qcs6490	qcs8300	qcs9100	qcs9100-rb8	qrb2210-rb1
BT_ON_OFF	🚫	🚫	✅ pass	✅ pass	✅ pass	⚠️ skip	✅ pass
CPUFreq_Validation	🚫	🚫	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass
Interrupts	🚫	🚫	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass
OpenCV	🚫	🚫	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass
WiFi_Firmware_Driver	🚫	🚫	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass
WiFi_OnOff	🚫	🚫	✅ pass	✅ pass	✅ pass	⚠️ skip	✅ pass
adsp_remoteproc	🚫	🚫	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass
boot	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass
cdsp_remoteproc	🚫	🚫	✅ pass	🚫	✅ pass	✅ pass	⚠️ skip
hotplug	🚫	🚫	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass
irq	🚫	🚫	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass

All jobs summary

Job ID	Device	State	Health
136679	qrb2210-rb1	Finished	Complete
136697	qrb2210-rb1	Finished	Complete
136677	qcs6490	Finished	Complete
136682	dragonboard-820c	Finished	Complete
136678	qcs9100	Finished	Complete
136681	qcs9100	Finished	Complete
136676	qcs9100-rb8	Finished	Complete
136686	qcs9100-rb8	Finished	Complete
136687	qrb2210-rb1	Finished	Complete
136698	qcs8300	Finished	Complete
136685	qcs6490	Finished	Complete
136695	qcs9100-rb8	Finished	Complete
136696	qcs9100	Finished	Complete
136675	qcs8300	Finished	Complete
136680	dragonboard-410c	Finished	Complete
136688	qcs8300	Finished	Complete
136684	dragonboard-820c	Finished	Complete
136694	qcs6490	Finished	Complete
136683	dragonboard-410c	Finished	Complete

lumag · 2026-02-06T21:31:42Z

+                install -d ufs
+                deploy_partition_files ${DEPLOY_DIR_IMAGE}/${QCOM_PARTITION_FILES_SUBDIR_UFS} ufs
+            fi
+


Why is this code tied to the presense of the SPI NOR? What about devices which support UFS and eMMC, but they don't have SPI-NOR?

Initial intention here is to support both builds for Hamoa (may be applicable for Purwa/Glymur as well) as spinor exist and only two hlos images (efi/rootfs) in root folder. I am fine to generalize the design, but may not able to verify on all boards (some boards are not available), platform PoC of targets can decide whether to specify flags in machine conf and validate by themselves.

lumag · 2026-02-06T21:32:25Z

 QCOM_CDT_FILE = "IQ_X_EVK_CDT"
 QCOM_BOOT_FILES_SUBDIR = "iq-x7181"
 QCOM_PARTITION_FILES_SUBDIR ?= "partitions/iq-x7181-evk/ufs"
+QCOM_PARTITION_FILES_SUBDIR_NVME ?= "partitions/iq-x7181-evk/nvme"


Please update the commit message, explaining the reasons for the change rather than the patch itself.

…rages For targets with more than one storage type supported on single board, add support to deploy partition files for different storages in image folder. These partition files under subfolder can be used to create flashable builds as per need. Signed-off-by: Shoudi Li <shoudil@qti.qualcomm.com>

Create subfolder under image folder to place partition files for NVMe and UFS storage, which can be used to create flashable builds. Signed-off-by: Shoudi Li <shoudil@qti.qualcomm.com>

github-actions · 2026-02-10T07:02:49Z

Test run workflow

Test jobs for commit `55c9703`

Test	dragonboard-410c	dragonboard-820c	qcs6490	qcs8300	qcs9100	qcs9100-rb8	qrb2210-rb1
boot	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass

All jobs summary

Job ID	Device	State	Health
140502	qcs9100-rb8	Finished	Complete
140501	qcs6490	Finished	Complete
140504	qcs8300	Finished	Complete
140509	qrb2210-rb1	Finished	Complete
140505	qcs9100	Finished	Complete
140516	qcs6490	Finished	Complete
140518	qcs8300	Finished	Complete
140510	qcs9100-rb8	Finished	Complete
140512	dragonboard-820c	Finished	Complete
140492	qrb2210-rb1	Finished	Complete
140496	qcs8300	Finished	Complete
140506	dragonboard-410c	Finished	Complete
140519	qcs6490	Finished	Complete
140500	qcs8300	Finished	Complete
140508	qcs9100	Finished	Complete
140507	dragonboard-410c	Finished	Complete
140493	qrb2210-rb1	Finished	Complete
140495	dragonboard-820c	Finished	Complete
140511	dragonboard-410c	Finished	Complete
140514	dragonboard-820c	Finished	Complete
140499	qcs6490	Finished	Complete
140513	qcs9100	Finished	Complete
140497	dragonboard-820c	Finished	Complete
140503	qrb2210-rb1	Finished	Complete
140494	qcs9100	Finished	Complete
140498	qcs9100-rb8	Finished	Complete
140515	qcs9100-rb8	Finished	Incomplete
140517	dragonboard-410c	Finished	Complete

lumag · 2026-02-10T11:36:41Z


-    # partition bins/xml files
+    # partition bins/xml files for supported build by default
    if [ -n "${QCOM_PARTITION_FILES_SUBDIR}" ]; then


Should we drop QCOM_PARTITION_FILES_SUBDIR and always use one of NVME / UFS variants?

I think we need to keep this configurable (in machine conf) as different storage will be supported with priority across targets, especially on early BU stage.

Exactly! Supporting different storage means supporting both eMMC and UFS or UFS and NVME deployments.

github-actions · 2026-03-13T02:13:12Z

This pull request has been marked as stale due to 30 days of inactivity. To prevent automatic closure in 5 days, remove the stale label or add a comment. You can reopen a closed pull request at any time.

shoudil requested review from lumag, ndechesne, ricardosalveti, sbanerjee-quic and vkraleti as code owners January 29, 2026 09:58

lumag requested changes Jan 29, 2026

View reviewed changes

shoudil force-pushed the hamoa-ufs-nvme-build branch from 8ec40ab to b0b7e75 Compare January 30, 2026 03:36

shoudil changed the title ~~image_types_qcom: add support to deploy partition files for NVMe~~ Add support to deploy partition files for NVMe Jan 30, 2026

shoudil changed the title ~~Add support to deploy partition files for NVMe~~ Support builds for both UFS and NVMe on IQ-X7181 Jan 30, 2026

lumag requested changes Jan 30, 2026

View reviewed changes

shoudil force-pushed the hamoa-ufs-nvme-build branch from b0b7e75 to 9339632 Compare February 4, 2026 02:52

lumag requested changes Feb 6, 2026

View reviewed changes

shoudil force-pushed the hamoa-ufs-nvme-build branch from 9339632 to 600c521 Compare February 10, 2026 04:26

shoudil added 2 commits February 10, 2026 12:29

conf: deploy both NVMe and UFS partition files for IQ-X7181

55c9703

Create subfolder under image folder to place partition files for NVMe and UFS storage, which can be used to create flashable builds. Signed-off-by: Shoudi Li <shoudil@qti.qualcomm.com>

shoudil force-pushed the hamoa-ufs-nvme-build branch from 600c521 to 55c9703 Compare February 10, 2026 04:30

lumag reviewed Feb 10, 2026

View reviewed changes

github-actions Bot added the Stale label Mar 13, 2026

github-actions Bot closed this Mar 18, 2026

		@@ -18,6 +18,7 @@ QCOM_DTB_FILE ?= "dtb.bin"
		QCOM_BOOT_FILES_SUBDIR ?= ""

Conversation

shoudil commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lumag left a comment

Choose a reason for hiding this comment

Uh oh!

test-reporting-app Bot commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

shoudil commented Jan 30, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shoudil Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jan 30, 2026

Test run workflow

Test jobs for commit b0b7e75

All jobs summary

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shoudil Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Feb 10, 2026

Test run workflow

Test jobs for commit 55c9703

All jobs summary

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Mar 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shoudil commented Jan 29, 2026 •

edited

Loading

test-reporting-app Bot commented Jan 29, 2026 •

edited

Loading

shoudil Feb 4, 2026 •

edited

Loading

Test jobs for commit `b0b7e75`

shoudil Feb 10, 2026 •

edited

Loading

Test jobs for commit `55c9703`