Skip to content

QCLINUX: arm64: dts: qcom: lemans: remove GearVM reserved region to from iot memory map#592

Open
apateriy-qcom wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
apateriy-qcom:6.18.y
Open

QCLINUX: arm64: dts: qcom: lemans: remove GearVM reserved region to from iot memory map#592
apateriy-qcom wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
apateriy-qcom:6.18.y

Conversation

@apateriy-qcom
Copy link
Copy Markdown

This change is part of removing GearVM carveouts on both Lemans IOT and monaco.
GearVM is currently not loaded or launched on QLI targets.
lemans-auto still supports GearVM, we include in lemans-auto.dtsi.

CRs-Fixed: 4528975

…rom iot memory map

This change is part of removing GearVM carveouts on both Lemans IOT and monaco.
GearVM is currently not loaded or launched on QLI targets.
lemans-auto still supports GearVM, we include in lemans-auto.dtsi.

Signed-off-by: Anurag Pateriya <apateriy@qti.qualcomm.com>
@apateriy-qcom apateriy-qcom requested review from a team, jingyiwang42, ndechesne and yijiyang May 18, 2026 08:37
@qswat-orbit-external
Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4528975 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4528975
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@sgaud-quic
Copy link
Copy Markdown
Contributor

PR #592 — validate-patch

PR: #592

Verdict Issues Detailed Report
⚠️ 0 Full report
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #592QCLINUX: arm64: dts: qcom: lemans: remove GearVM reserved region to from iot memory map
Upstream commit: N/A — QCLINUX: prefix; no lore.kernel.org link expected or required
Verdict: ⚠️ PARTIAL

Scope note: QCLINUX: commits are vendor-only with no upstream lore equivalent. Lore-fetch, diff-comparison, and upstream-status steps are not applicable. Review is limited to commit-message hygiene and internal diff correctness.


Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: — no upstream to compare against
Body preserves rationale Explains GearVM not loaded on QLI targets; lemans-auto still needs it
Fixes tag present/correct N/A Not a bug-fix commit; no Fixes: tag needed
Authorship preserved Single author; Signed-off-by: matches From:
Backport note (if applicable) N/A Not a backport
Subject grammar Spurious word "to" in subject: "remove GearVM reserved region to from iot memory map" — should be "remove GearVM reserved region from iot memory map"

Diff

File Status Notes
arch/arm64/boot/dts/qcom/lemans-auto.dtsi ⚠️ Adds firmware_mem and scmi_mem nodes — but scmi_mem size is 0x100000 (1 MB), different from the 0x40000 (256 KB) being removed from lemans.dtsi
arch/arm64/boot/dts/qcom/lemans.dtsi Removes firmware_mem and scmi_mem nodes cleanly; surrounding context intact

Issues

  1. Subject line typo — The word "to" is spurious in "remove GearVM reserved region to from iot memory map". Correct to: "remove GearVM reserved region from iot memory map".

  2. Silent scmi_mem size change — The node removed from lemans.dtsi has reg = <0x0 0xd0000000 0x0 0x40000> (256 KB), but the node added to lemans-auto.dtsi has reg = <0x0 0xd0000000 0x0 0x100000> (1 MB). This is a 4× size increase that is not mentioned anywhere in the commit message. If intentional (e.g., auto variant needs more SCMI memory), it must be documented. If unintentional, the size should remain 0x40000.


Upstream Patch Status

Commit Community Verdict
QCLINUX: arm64: dts: qcom: lemans: remove GearVM reserved region… ⏭️ Not applicable — QCLINUX: vendor-only commit; no upstream posting expected

qcom-next Presence

Commit Status
QCLINUX: arm64: dts: qcom: lemans: remove GearVM reserved region… ⏭️ Skipped — kernel tree clone not permitted in this environment; verify manually

Verdict

Request changes. The commit message has a grammatical error in the subject line ("to from") that must be fixed. More importantly, the scmi_mem reserved-memory region silently changes size from 256 KB (0x40000) to 1 MB (0x100000) when moved from lemans.dtsi to lemans-auto.dtsi — this undocumented size change must either be explained in the commit body (if intentional for the auto variant) or corrected to preserve the original size.


Final Summary

  1. Lore link present: No — QCLINUX: prefix; none expected; validation not applicable
  2. Lore link matches PR commits: N/A
  3. Upstream patch status: N/A — vendor-only commit
  4. PR present in qcom-next: ⏭️ Skipped — verify manually

@sgaud-quic
Copy link
Copy Markdown
Contributor

PR #592 — checker-log-analyzer

PR: #592
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26022778076

Checker Result Summary
Checker Result Summary
checkpatch 1 WARNING: COMMIT_LOG_LONG_LINE in commit body
dt-binding-check ⏭️ No changes in Documentation/devicetree/bindings
dtb-check Log Summary: Test passed
sparse-check ⏭️ Skipping sparse check as nothing changed
check-uapi-headers ⏭️ Skipping uapi check as nothing changed
check-patch-compliance QCLINUX: prefix not in allowed list
tag-check QCLINUX: prefix — vendor-only commit on qcom-6.18.y
qcom-next-check N/A Target is qcom-6.18.y, not qcom-next

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: QCLINUX: arm64: dts: qcom: lemans: remove GearVM reserved region to from iot memory map (#592)
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26022778076
Target branch: qcom-6.18.y (not qcom-next / qcom-next-staging → tag-check is mandatory)
Base SHA: 6964936c9bfc3337aa8ba8a0fb25021d06e5ce04
Head SHA: cb246c564610f061e080455f4e72123ecc05b80c

Checker Result Summary
checkpatch 1 WARNING: COMMIT_LOG_LONG_LINE in commit body
dt-binding-check ⏭️ No changes in Documentation/devicetree/bindings
dtb-check Log Summary: Test passed
sparse-check ⏭️ Skipping sparse check as nothing changed
check-uapi-headers ⏭️ Skipping uapi check as nothing changed
check-patch-compliance QCLINUX: prefix not in allowed list
tag-check QCLINUX: prefix — vendor-only commit on qcom-6.18.y
qcom-next-check N/A Target is qcom-6.18.y, not qcom-next

❌ checkpatch

Root cause: The commit body contains a line exceeding 75 characters, triggering COMMIT_LOG_LONG_LINE.

Failure details:

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#7:
This change is part of removing GearVM carveouts on both Lemans IOT and monaco.

Commit cb246c564610 ("QCLINUX: arm64: dts: qcom: lemans: remove GearVM reserved region to from iot memory map") has style problems, please review.

cb246c564610f061e080455f4e72123ecc05b80c total: 0 errors, 1 warnings, 0 checks, 37 lines checked

Fix: Wrap the offending commit-body line at 75 characters:

This change is part of removing GearVM carveouts on both
Lemans IOT and monaco.

Then amend the commit:

git rebase -i 6964936c9bfc   # mark commit as 'edit'
git commit --amend            # rewrap the body line
git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES \
  --git 6964936c9bfc3337aa8ba8a0fb25021d06e5ce04..cb246c564610f061e080455f4e72123ecc05b80c

❌ check-patch-compliance

Root cause: The commit subject starts with QCLINUX:, which is not in the allowed prefix list for check-patch-compliance (the checker only accepts FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: lemans: remove GearVM reserved region to from iot memory map
Commit summary does not start with a required prefix
Process completed with exit code 1.

Fix: This is a known checker limitation for vendor-only commits. QCLINUX: is the correct prefix for a change that has no upstream equivalent (GearVM carveout removal is QLI-specific). The checker will always fail for QCLINUX: commits on non-qcom-next branches. No patch change is needed if this is genuinely a vendor-only change. If the patch has been or will be posted upstream, change the prefix to FROMLIST: and add a Link: trailer.

Reproduce locally:

bash kernel-checkers/check-patch-compliance.sh --kernel-src <kernel> \
  --base 6964936c9bfc3337aa8ba8a0fb25021d06e5ce04 \
  --head cb246c564610f061e080455f4e72123ecc05b80c

❌ tag-check

Root cause: Target branch is qcom-6.18.y (not qcom-next / qcom-next-staging), so every commit must start with a recognized prefix. QCLINUX: is a valid prefix for this check — however, the commit is a vendor-only DTS change with no upstream posting, so QCLINUX: is the correct and only appropriate prefix here.

Assessment: QCLINUX: is in the required prefix list (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, WORKAROUND:). The tag-check itself should pass for this commit. The failure is entirely in check-patch-compliance, not in the subject-prefix rule. No fix needed for tag-check.


Verdict

1 real blocker to fix before merge:

  • checkpatch COMMIT_LOG_LONG_LINE — wrap the commit body line "This change is part of removing GearVM carveouts on both Lemans IOT and monaco." to ≤75 chars and amend the commit.

1 known false-positive (no patch change needed):

  • check-patch-compliance — fails because QCLINUX: is not in the compliance checker's allowed-prefix list. This is a documented limitation for vendor-only commits. Since this is a QLI-specific GearVM carveout removal with no upstream equivalent, QCLINUX: is the correct prefix and the failure can be waived.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants