Skip to content

PENDING: arm64: dts: qcom: lemans: remove GearVM reserved region to from iot memory map#1169

Open
apateriy-qcom wants to merge 1 commit into
qualcomm-linux:tech/all/dt/qcs9100from
apateriy-qcom:qcs9100
Open

PENDING: arm64: dts: qcom: lemans: remove GearVM reserved region to from iot memory map#1169
apateriy-qcom wants to merge 1 commit into
qualcomm-linux:tech/all/dt/qcs9100from
apateriy-qcom:qcs9100

Conversation

@apateriy-qcom
Copy link
Copy Markdown

@apateriy-qcom apateriy-qcom commented May 18, 2026

This change is part of removing GearVM carveouts on both Lemans IOT and monaco.
GearVM is currently not loaded or launched on QLI targets.
lemans-auto still supports GearVM, we include in lemans-auto.dtsi.

CRs-Fixed: 4528975

@qswat-orbit-external
Copy link
Copy Markdown

Merge Check Failed: No Component Found

Configuration Error: No component found for branch 'tech/all/dt/qcs9100'.

There is no component associated with the provided branch in Polaris. Please verify the branch configuration.

Branch: tech/all/dt/qcs9100

@qcomlnxci qcomlnxci requested review from a team, aiquny, mukeshojha-linux and shashim-quic and removed request for a team May 18, 2026 07:50
@sgaud-quic
Copy link
Copy Markdown
Contributor

PR #1169 — validate-patch

PR: #1169

Verdict Issues Detailed Report
0 Full report
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: QCLINUX: arm64: dts: qcom: lemans: remove GearVM reserved region to from iot memory map — PR #1169
Upstream commit: N/A — QCLINUX: prefix; no upstream lore link expected
Verdict: ✅ PASS (validation not applicable — vendor-only commit)


Step 1 — Lore Link Check

The commit subject carries the QCLINUX: prefix. Per the skill's prefix table:

QCLINUX: — Vendor-only, no upstream equivalent. No link expected — skip validation.

No Link: tag is present in the commit message, which is correct and expected for this prefix. The skill mandates bailing out with a "not applicable" note rather than a FAIL for QCLINUX: commits.

PR changes files:

  • arch/arm64/boot/dts/qcom/lemans-auto.dtsi
  • arch/arm64/boot/dts/qcom/lemans.dtsi

Step 2–9 — Upstream Fetch / Diff Comparison

Skipped — not applicable for QCLINUX: commits. There is no lore.kernel.org source to compare against.


Step 10 — qcom-next Presence

Network access is restricted in this environment; a clone/fetch of qualcomm-linux/kernel cannot be performed.

Result: ⏭️ Skipped — could not fetch qcom-next; verify manually.


Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: — no upstream source
Body preserves rationale Explains GearVM not loaded on QLI targets; lemans-auto still supports it
Fixes tag present/correct N/A Not a bug-fix backport
Authorship preserved Author and Signed-off-by: are consistent (Anurag Pateriya)
Backport note (if applicable) N/A Not a backport
Co-developed-by used correctly Not present (not needed)

Minor note: The subject line contains a grammatical artifact — "remove GearVM reserved region to from iot memory map" — the word "to" is spurious. This is cosmetic only and does not affect correctness.


Diff

File Status Notes
arch/arm64/boot/dts/qcom/lemans-auto.dtsi Adds firmware_mem and scmi_mem reserved regions (moved from lemans.dtsi)
arch/arm64/boot/dts/qcom/lemans.dtsi Removes firmware_mem and scmi_mem reserved regions

Noteworthy diff detail: The scmi_mem size changes between the two files:

  • Removed from lemans.dtsi: reg = <0x0 0xd0000000 0x0 0x40000> (256 KiB)
  • Added to lemans-auto.dtsi: reg = <0x0 0xd0000000 0x0 0x100000> (1 MiB)

This is a size increase (4×), not a straight move. The commit message does not explain this discrepancy. This warrants a ⚠️ review comment — it may be intentional for the auto variant but should be documented.


Upstream Patch Status

Commit Community Verdict
QCLINUX: arm64: dts: qcom: lemans: remove GearVM reserved region… ⏭️ Skipped — QCLINUX: vendor-only commit; no upstream lore thread exists

Dependency Check

  • The change moves two reserved-memory nodes (firmware_mem, scmi_mem) from the shared lemans.dtsi into lemans-auto.dtsi. Any DTS that includes lemans.dtsi but not lemans-auto.dtsi (i.e. the IOT/QLI variant) will lose these reservations — which is the stated intent.
  • No Depends-on: or prerequisite patches are mentioned; the change is self-contained within the two files.
  • ✅ No missing dependencies identified.

Issues

  1. ⚠️ scmi_mem size mismatch — The region is removed from lemans.dtsi at 0x40000 (256 KiB) but re-added to lemans-auto.dtsi at 0x100000 (1 MiB). This is a silent size change bundled into what the commit message describes as a pure "move". The commit message should explicitly document why the size differs for the auto variant.

  2. ℹ️ Cosmetic subject typo — "remove GearVM reserved region to from iot memory map" — the word "to" is extraneous.


Verdict

QCLINUX: vendor-only commit — lore validation is not applicable and the patch is structurally correct. The one item requiring attention before merge is the undocumented scmi_mem size change (256 KiB → 1 MiB) between lemans.dtsi and lemans-auto.dtsi; the commit message should be amended to explain this intentional size difference.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore.kernel.org link required or expected
  2. Lore link matches PR commits: N/A — validation not applicable for QCLINUX: commits
  3. Upstream patch status: ⏭️ Skipped — vendor-only change with no upstream lore thread
  4. PR present in qcom-next: ⏭️ Skipped — could not fetch qcom-next (network restricted); verify manually

@sgaud-quic
Copy link
Copy Markdown
Contributor

PR #1169 — checker-log-analyzer

PR: #1169
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26020523221

Checker Result Summary
Checker Result Summary
checkpatch COMMIT_LOG_LONG_LINE warning — commit body line exceeds 75 chars
dt-binding-check ⏭️ No changes in Documentation/devicetree/bindings — skipped
dtb-check Log Summary: Test passed — no new DTB errors introduced
sparse-check ⏭️ No C/H files changed — skipped
check-uapi-headers ⏭️ No relevant files changed — skipped
check-patch-compliance QCLINUX: prefix not in allowed list — commit fails prefix check
tag-check QCLINUX: is a valid vendor-only prefix for this branch
qcom-next-check N/A Target branch is tech/all/dt/qcs9100, not qcom-next

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: QCLINUX: arm64: dts: qcom: lemans: remove GearVM reserved region to from iot memory map (#1169)
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26020523221

Target branch: tech/all/dt/qcs9100 (not qcom-next / qcom-next-staging → tag-check is mandatory)

Checker Result Summary
checkpatch COMMIT_LOG_LONG_LINE warning — commit body line exceeds 75 chars
dt-binding-check ⏭️ No changes in Documentation/devicetree/bindings — skipped
dtb-check Log Summary: Test passed — no new DTB errors introduced
sparse-check ⏭️ No C/H files changed — skipped
check-uapi-headers ⏭️ No relevant files changed — skipped
check-patch-compliance QCLINUX: prefix not in allowed list — commit fails prefix check
tag-check QCLINUX: is a valid vendor-only prefix for this branch
qcom-next-check N/A Target branch is tech/all/dt/qcs9100, not qcom-next

❌ checkpatch

Root cause: The commit body contains a line longer than 75 characters, triggering COMMIT_LOG_LONG_LINE.

Failure details:

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#7:
This change is part of removing GearVM carveouts on both Lemans IOT and monaco.

Commit f33480d7d155 ("QCLINUX: arm64: dts: qcom: lemans: remove GearVM reserved region to from iot memory map")
has style problems, please review.

f33480d7d155fe6b9d655da211beb6de230b64de total: 0 errors, 1 warnings, 0 checks, 37 lines checked

Fix: Wrap the offending commit body line at 75 characters:

# Before (82 chars):
This change is part of removing GearVM carveouts on both Lemans IOT and monaco.

# After (split at word boundary ≤75 chars):
This change is part of removing GearVM carveouts on both
Lemans IOT and monaco.

Then amend the commit:

git rebase -i <base_sha>   # mark commit f33480d7d155 as 'edit'
# edit the commit message body
git commit --amend
git rebase --continue

Reproduce locally:
./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES --git 9f3cbcbfaa5a143d339bcabf1a6a6ac98107e084..7dc9d9c5581520ce965045665892ee25fd4ebc18


❌ check-patch-compliance

Root cause: The commit subject starts with QCLINUX:, which is not in the check-patch-compliance allowed prefix list (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:). This is a known checker limitation for vendor-only commits.

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: lemans: remove GearVM reserved region to from iot memory map
Commit summary does not start with a required prefix
Process completed with exit code 1.

Fix: This is a vendor-only DTS change with no upstream equivalent. The QCLINUX: prefix is correct for this type of change. The check-patch-compliance checker will always fail for QCLINUX: commits — this is a known limitation and not a real defect in the patch. No patch change is needed; the reviewer/maintainer should acknowledge this as a false positive for vendor-only commits.

If the change has been or will be posted upstream, change the prefix to FROMLIST: and add a Link: <lore-url> trailer to resolve the failure.

Reproduce locally:
bash kernel-checkers/check-patch-compliance.sh --kernel-src <kernel> --base <base_sha> --head <head_sha>


Verdict

1 real blocker, 1 known false positive:

  • Fix the COMMIT_LOG_LONG_LINE checkpatch warning by wrapping the commit body line at 75 chars (1-line amend).
  • The check-patch-compliance failure is a known limitation for QCLINUX: vendor-only commits — no patch change required; maintainer should waive it.

@qcomlnxci qcomlnxci requested a review from a team May 18, 2026 09:06
… iot memory map

This change is part of removing GearVM carveouts on Lemans IOT.
GearVM is currently not loaded or launched on QLI targets.
lemans-auto still supports GearVM, we include in lemans-auto.dtsi.

Signed-off-by: Anurag Pateriya <apateriy@qti.qualcomm.com>
@apateriy-qcom apateriy-qcom changed the title QCLINUX: arm64: dts: qcom: lemans: remove GearVM reserved region to from iot memory map PENDING: arm64: dts: qcom: lemans: remove GearVM reserved region to from iot memory map May 18, 2026
@sgaud-quic
Copy link
Copy Markdown
Contributor

PR #1169 — validate-patch

PR: #1169

Verdict Issues Detailed Report
⚠️ 0 Full report
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: PENDING: arm64: dts: qcom: lemans: remove GearVM reserved region from iot memory map — PR #1169
Upstream commit: N/A — PENDING: prefix; no lore.kernel.org link by design
Verdict: ⚠️ PARTIAL — lore validation not applicable for PENDING: commits; internal diff is self-consistent


Commit Message

Check Status Note
Subject matches upstream N/A PENDING: — no upstream posting exists
Body preserves rationale Explains GearVM not loaded on QLI targets; lemans-auto still needs it
Fixes tag present/correct N/A Not a bug-fix commit; no Fixes: tag required
Authorship preserved Single author; Signed-off-by: matches From:
Backport note (if applicable) N/A Not a backport
Link: tag Correctly absent for PENDING:
Co-developed-by: misuse Not present; no issue

Diff

File Status Notes
arch/arm64/boot/dts/qcom/lemans-auto.dtsi Adds firmware_mem and scmi_mem nodes — exact mirror of what is removed from lemans.dtsi
arch/arm64/boot/dts/qcom/lemans.dtsi Removes firmware_mem and scmi_mem nodes — reg values, labels, and no-map properties are identical to the additions in lemans-auto.dtsi

Upstream Patch Status

Commit Community Verdict
arm64: dts: qcom: lemans: remove GearVM reserved region from iot memory map ⏳ Decision Pending (not posted) — PENDING: prefix indicates patch has not been submitted to the mailing list

qcom-next Presence

Commit Status
arm64: dts: qcom: lemans: remove GearVM reserved region from iot memory map ⏭️ Skipped — git not available and network restricted; verify manually

Issues

  • None affecting correctness. The PENDING: prefix is intentional and correctly used — no lore link is expected or required.

Verdict

The patch is internally correct and the PENDING: prefix is appropriate — the diff faithfully moves firmware_mem and scmi_mem reserved-memory nodes from the shared lemans.dtsi to the auto-specific lemans-auto.dtsi with no semantic changes; merge as-is once the change is ready to be upstreamed or promoted to FROMLIST:.

@sgaud-quic
Copy link
Copy Markdown
Contributor

PR #1169 — checker-log-analyzer

PR: #1169
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26024308085

Checker Result Summary
Checker Result Summary
checkpatch 0 errors, 0 warnings — clean
dt-binding-check ⏭️ No changes in Documentation/devicetree/bindings
dtb-check Log Summary: Test passed
sparse-check ⏭️ Skipping sparse check — no C/H files changed
check-uapi-headers ⏭️ Skipping uapi check — no C/H files changed
check-patch-compliance PENDING: prefix not in allowed list
tag-check PENDING: is a valid tag-check prefix
qcom-next-check N/A Target branch is tech/all/dt/qcs9100, not qcom-next

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: PENDING: arm64: dts: qcom: lemans: remove GearVM reserved region from iot memory map (#1169)
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26024308085

Checker Result Summary
checkpatch 0 errors, 0 warnings — clean
dt-binding-check ⏭️ No changes in Documentation/devicetree/bindings
dtb-check Log Summary: Test passed
sparse-check ⏭️ Skipping sparse check — no C/H files changed
check-uapi-headers ⏭️ Skipping uapi check — no C/H files changed
check-patch-compliance PENDING: prefix not in allowed list
tag-check PENDING: is a valid tag-check prefix
qcom-next-check N/A Target branch is tech/all/dt/qcs9100, not qcom-next

❌ check-patch-compliance

Root cause: The single commit uses the PENDING: prefix, which check-patch-compliance does not accept — it requires FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT:.

Failure details:

Checking commit: PENDING: arm64: dts: qcom: lemans: remove GearVM reserved region from iot memory map
Commit summary does not start with a required prefix
Process completed with exit code 1.

Fix:

This is a vendor-only / work-in-progress change with no upstream lore posting. Two options:

  1. If the patch has been posted to lore.kernel.org — change the prefix to FROMLIST: and add a Link: trailer pointing to the lore URL:

    git rebase -i <base_sha>   # mark commit as 'edit'
    git commit --amend -m "FROMLIST: arm64: dts: qcom: lemans: remove GearVM reserved region from iot memory map"
    # also add to commit body:  Link: https://lore.kernel.org/r/<message-id>
    git rebase --continue
  2. If the patch has NOT been posted upstreamcheck-patch-compliance will always fail for PENDING: commits; this is a known checker limitation for vendor-only/WIP commits. No patch change can fix it — the failure must be accepted or the patch posted upstream first.

Reproduce locally:

# Run the compliance checker against the commit
bash kernel-checkers/check-patch-compliance.sh --kernel-src <kernel> \
  --base <base_sha> --head <head_sha>

Verdict

1 blocker: check-patch-compliance fails because the commit uses PENDING: prefix. If this is intentionally a vendor-only/WIP change not yet posted upstream, the failure is a known checker limitation and cannot be resolved without either posting the patch to lore (then switching to FROMLIST:) or accepting the CI failure for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants