Skip to content

PENDING: arm64: dts: qcom: glymur: add Coresight devices for APSS debug block#1168

Open
jiegan0107 wants to merge 1 commit into
qualcomm-linux:tech/overlay/dtfrom
jiegan0107:tech/overlay/dt
Open

PENDING: arm64: dts: qcom: glymur: add Coresight devices for APSS debug block#1168
jiegan0107 wants to merge 1 commit into
qualcomm-linux:tech/overlay/dtfrom
jiegan0107:tech/overlay/dt

Conversation

@jiegan0107
Copy link
Copy Markdown

Add the following devices that are part of the APSS debug block to enable debug features, including ETM, replicator, funnel, and TMC ETF.

@qcomlnxci qcomlnxci requested review from a team, Komal-Bajaj, quic-kaushalk and trsoni and removed request for a team May 18, 2026 07:36
@qcomlnxci qcomlnxci requested a review from a team May 18, 2026 07:43
@sgaud-quic
Copy link
Copy Markdown
Contributor

PR #1168 — validate-patch

PR: #1168

Verdict Issues Detailed Report
0 Full report
Verdict: ❌ — click to expand

Patch Validation Report

PR: PR #1168PENDING: arm64: dts: qcom: glymur: add Coresight devices for APSS debug block
Upstream: (none — PENDING: prefix)
Verdict: ❌ FAIL (validation not applicable)

Commit Message

Check Status Note
Subject matches upstream N/A PENDING: prefix — no upstream posting exists
Body preserves rationale N/A Vendor-only work-in-progress
Fixes tag present/correct N/A Not applicable for PENDING:
Authorship preserved Signed-off-by matches From: (Jie Gan)
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/glymur-staging.dtso N/A Cannot compare — no lore upstream to diff against

Upstream Patch Status

Commit Community Verdict
PENDING: arm64: dts: qcom: glymur: add Coresight devices for APSS debug block ⏳ Decision Pending — PENDING: prefix indicates patch has not been posted to any mailing list yet

qcom-next Presence

Commit Status
PENDING: arm64: dts: qcom: glymur: add Coresight devices for APSS debug block ⏭️ Skipped — PENDING: commits are not expected in qcom-next

Issues Found

  1. No lore.kernel.org link — The PENDING: prefix explicitly signals this patch has not been posted upstream. This is by design and not an error per se, but it means lore-based validation is impossible.
  2. Staging file target — The patch modifies glymur-staging.dtso, which is appropriate for work-in-progress Coresight DT additions that are not yet ready for upstream submission.

Recommendation

This commit carries the PENDING: prefix, which by convention means it is vendor-internal work-in-progress with no upstream lore equivalent. Lore-based diff validation is not applicable. The patch itself adds 1,235 lines of Coresight topology (18 ETMs, 9 replicators, 9 funnels, 3 TMC ETFs, 1 APSS funnel) to the glymur staging overlay. Before promoting this to FROMLIST:, the author should post the series to the appropriate mailing list (linux-arm-msm / coresight maintainers) and update the prefix to FROMLIST: with a Link: tag.

Final Summary

  1. Lore link present: No — PENDING: prefix; no lore.kernel.org link found or expected
  2. Lore link matches PR commits: N/A — validation skipped for PENDING: commits by skill design
  3. Upstream patch status: ⏳ Decision Pending — patch has not been posted to any mailing list; vendor-internal WIP
  4. PR present in qcom-next: ⏭️ Skipped — PENDING: commits are not tracked in qcom-next

@sgaud-quic
Copy link
Copy Markdown
Contributor

PR #1168 — checker-log-analyzer

PR: #1168
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26020223968

Checker Result Summary
Checker Result Summary
checkpatch All 4 commits clean — 0 errors, 0 warnings
dt-binding-check ⏭️ No changes in Documentation/devicetree/bindings
dtb-check No new DTB errors introduced by PR (diff vs base is empty)
sparse-check ⏭️ No C/H file changes — skipped
check-uapi-headers ⏭️ No C/H file changes — skipped
check-patch-compliance All 4 commits use PENDING: prefix — not in allowed list
tag-check PENDING: is a valid tag-check prefix for tech/overlay/dt
qcom-next-check N/A Not a qcom-next / qcom-next-staging target

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: PENDING: arm64: dts: qcom: glymur: add Coresight devices for APSS debug block — #1168
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26020223968
Target branch: tech/overlay/dt (not qcom-next / qcom-next-staging → prefix check applies)

Checker Result Summary
checkpatch All 4 commits clean — 0 errors, 0 warnings
dt-binding-check ⏭️ No changes in Documentation/devicetree/bindings
dtb-check No new DTB errors introduced by PR (diff vs base is empty)
sparse-check ⏭️ No C/H file changes — skipped
check-uapi-headers ⏭️ No C/H file changes — skipped
check-patch-compliance All 4 commits use PENDING: prefix — not in allowed list
tag-check PENDING: is a valid tag-check prefix for tech/overlay/dt
qcom-next-check N/A Not a qcom-next / qcom-next-staging target

❌ check-patch-compliance

Root cause: All 4 commits use the PENDING: prefix, which check-patch-compliance does not accept — it is a known checker limitation for vendor-only / not-yet-posted commits.

Failure details:

Checking commit: PENDING: arm64: dts: qcom: hamoa: add TGU in staging dtso
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: dts: qcom: sm8750: add TGU in staging dtso
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: dts: qcom: kaanapali: add TGU in staging dtso
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: dts: qcom: glymur: add Coresight devices for APSS debug block
Commit summary does not start with a required prefix

##[error]Process completed with exit code 1.

Fix options (choose one per commit):

Scenario Action
Patch has been posted to lore.kernel.org Change prefix to FROMLIST: and add Link: <lore-url> to commit body
Patch is in a maintainer tree but not yet in Linus's tree Change prefix to FROMGIT: and add Link: <git-url>
Patch is vendor-only with no upstream equivalent Change prefix to QCLINUX: — note: check-patch-compliance will still fail for QCLINUX: commits; this is a known checker limitation
Patch is genuinely not yet posted upstream Keep PENDING: — this failure is expected and is a known checker limitation; no patch change needed if the intent is to track it as pending

Fix command (if changing prefix):

git rebase -i <base_sha>   # mark each commit as 'edit'
git commit --amend -m "FROMLIST: arm64: dts: qcom: hamoa: add TGU in staging dtso"
git rebase --continue
# repeat for each commit

Reproduce locally:

bash kernel-checkers/check-patch-compliance.sh \
  --kernel-src ./kernel \
  --base 9f3cbcbfaa5a143d339bcabf1a6a6ac98107e084 \
  --head df9734c7d5f3e4d89c8617e2f6f82e453df944fe

Verdict

1 blocker: check-patch-compliance fails on all 4 commits due to the PENDING: prefix. This is a known checker limitationPENDING: is intentionally not in the compliance checker's allowed list. If these patches are genuinely pending (not yet posted upstream), the failure is expected and can be waived. If any of the patches have since been posted to lore, update those commits to FROMLIST: + Link: to clear the failure.

…ug block

Add the following devices that are part of the APSS debug block to
enable debug features, including ETM, replicator, funnel, and
TMC ETF.

Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants