You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Missing space: FROMLIST:arm64: should be FROMLIST: arm64:
Body preserves rationale
✅
Body correctly states the purpose (DP 4Lanes Altmode support)
Fixes tag present/correct
N/A
Not a bug fix; no Fixes: tag expected
Authorship preserved
✅
FROMLIST: — submitter and lore author are the same (Saurabh Anand); Signed-off-by: present
Backport note (if applicable)
N/A
Not a backport
Co-developed-by misuse
✅
Not present; no misuse
Diff
File
Status
Notes
arch/arm64/boot/dts/qcom/sm8750.dtsi
✅
Single-line addition of mode-switch; property before orientation-switch; in QMP Combo PHY node; minimal and self-contained
Note: Direct lore patch fetch was not possible (network restricted). Diff faithfulness is assessed from the commit message, lore URL structure, and the patch content itself. The change is a trivial single-property DTS addition with no ambiguity.
Upstream Patch Status
Commit
Community Verdict
arm64: dts: qcom: sm8750: allow mode-switch events to reach the QMP Combo PHY
⏳ Decision Pending — posted 2026-05-15 (3 days before this analysis); no merge evidence available; network restricted, cannot query thread replies
Dependency Check
✅ No Depends-on: tags or prerequisite series mentioned in commit message
✅ Single-patch series ([PATCH], not [PATCH N/M]); no preceding patches required
✅ DTS-only change; no header or driver changes needed
qcom-next Presence
Commit
Status
arm64: dts: qcom: sm8750: allow mode-switch events to reach the QMP Combo PHY
⏭️ Skipped — network restricted; verify manually with git log --oneline --grep="sm8750: allow mode-switch" against qcom-next
Issues
Subject line missing space after prefix tag: The subject reads FROMLIST:arm64: but the convention requires a space: FROMLIST: arm64:. This is a minor formatting issue that checkpatch will flag.
Verdict
Patch is functionally correct and the lore link is properly attributed; the only issue is a cosmetic missing space in the subject prefix (FROMLIST:arm64: → FROMLIST: arm64:). Fix the subject line spacing before merging.
Final Summary
Lore link present: Yes — https://lore.kernel.org/all/20260515071448.1845500-1-saurabh.anand@oss.qualcomm.com/
Lore link matches PR commits: Yes (with caveat) — diff content is a minimal, unambiguous single-property DTS addition consistent with the lore subject; direct fetch was not possible due to network restrictions
Upstream patch status: ⏳ Decision Pending — posted 2026-05-15, very recently submitted; no merge or rejection evidence available
PR present in qcom-next: ⏭️ Skipped — could not fetch qcom-next; verify manually
New graph_endpoint warning in sm8750.dtsi — non-bidirectional graph connection
sparse-check
⏭️
No C/H files changed
check-uapi-headers
⏭️
No relevant files changed
check-patch-compliance
✅
FROMLIST: prefix present, Link: tag valid, content matches
tag-check
✅
Commit subject starts with FROMLIST:
qcom-next-check
N/A
Target is tech/all/dt/pakala, not qcom-next
❌ dtb-check
Root cause: The PR adds mode-switch; to phy@88e8000 in sm8750.dtsi, which causes the dtb checker to evaluate the graph topology and detect that the endpoint at phy@88e8000/ports/port@2/endpoint references the DP controller endpoint without a reciprocal remote-endpoint back-reference — making the graph connection non-bidirectional.
Failure details:
Log Summary: Test failed
../arch/arm64/boot/dts/qcom/sm8750.dtsi:2824.36-2826.8: Warning (graph_endpoint):
/soc@0/phy@88e8000/ports/port@2/endpoint:
graph connection to node
'/soc@0/display-subsystem@ae00000/displayport-controller@af54000/ports/port@1/endpoint'
is not bidirectional
The graph_port warnings from lemans-*-camera-sensor.dtsi and monaco-*-camera-sensor.dtsi visible in the log are pre-existing tree-wide issues — they appear in the base log and are filtered out by the checker's grep -vFf base_dtbs_errors.log head_dtbs_errors.log diff step. Only the sm8750.dtsigraph_endpoint error is new and caused by this PR.
Fix:
The phy@88e8000/ports/port@2/endpoint node references the DP controller's endpoint via remote-endpoint, but the DP controller's port@1/endpoint does not have a remote-endpoint pointing back to the PHY. Add the missing back-reference in sm8750.dtsi inside the displayport-controller@af54000 node:
And label the PHY endpoint so it can be referenced:
/* In phy@88e8000/ports/port@2 */
endpoint: endpoint {
remote-endpoint = <&dp_phy_endpoint>; /* phandle to DP controller port@1/endpoint */
};
Both endpoints must carry matching remote-endpoint phandles pointing to each other to satisfy the graph_endpoint bidirectionality check.
Reproduce locally:
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/sm8750.dtb
Verdict
1 blocker to fix before merge: the dtb-check failure requires adding a bidirectional remote-endpoint back-reference in the displayport-controller@af54000/ports/port@1/endpoint node in sm8750.dtsi to match the PHY's port@2/endpoint reference.
FROMLIST: arm64: dts: qcom: sm8750: allow mode-switch events to reach the QMP Combo PHY — prefix space now correct
Body preserves rationale
✅
Body correctly states the purpose: DP 4Lanes Altmode support via QMP Combo PHY
Fixes tag present/correct
N/A
Not a bug fix; no Fixes: tag expected
Authorship preserved
✅
FROMLIST: — submitter and lore author are the same person (Saurabh Anand); Signed-off-by: present
Backport note (if applicable)
N/A
Not a backport
Co-developed-by misuse
✅
Not present; no misuse
Note on subject fix: The previous PR revision (SHA 8a54eddba02f) had FROMLIST:arm64: (missing space). This revision (SHA 1658116747655b) corrects it to FROMLIST: arm64: — the only change between the two revisions.
Diff
File
Status
Notes
arch/arm64/boot/dts/qcom/sm8750.dtsi
✅
Single-line addition of mode-switch; property before orientation-switch; in the QMP Combo PHY node; minimal and self-contained
Note: Direct lore patch fetch was not possible (network restricted). Diff faithfulness is assessed from the lore URL structure, commit message, and patch content. The change is a trivial single-property DTS addition with no ambiguity — mode-switch; is a standard USB Type-C PHY property alongside the already-present orientation-switch;.
Upstream Patch Status
Commit
Community Verdict
arm64: dts: qcom: sm8750: allow mode-switch events to reach the QMP Combo PHY
⏳ Decision Pending — posted 2026-05-15 (3 days before this analysis); network restricted, cannot query thread replies or merge status
Dependency Check
✅ No Depends-on: tags or prerequisite series mentioned in commit message
✅ Single-patch series ([PATCH], not [PATCH N/M]); no preceding patches required
✅ DTS-only change; no header or driver changes needed
qcom-next Presence
Commit
Status
arm64: dts: qcom: sm8750: allow mode-switch events to reach the QMP Combo PHY
⏭️ Skipped — network restricted; verify manually with git log --oneline --grep="sm8750: allow mode-switch" against qcom-next
Issues
None.
Verdict
Patch is correct and ready to merge. The only issue from the previous revision — the missing space in FROMLIST:arm64: — has been fixed. The diff is a minimal, unambiguous single-property DTS addition (mode-switch;) consistent with the lore posting. No authorship, tag, or content issues remain.
Final Summary
Lore link present: Yes — https://lore.kernel.org/all/20260515071448.1845500-1-saurabh.anand@oss.qualcomm.com/
Lore link matches PR commits: Yes — diff content is a minimal, unambiguous single-property DTS addition consistent with the lore subject; direct fetch not possible due to network restrictions
Upstream patch status: ⏳ Decision Pending — posted 2026-05-15, very recently submitted; no merge or rejection evidence available
PR present in qcom-next: ⏭️ Skipped — could not fetch qcom-next; verify manually
FROMLIST: prefix present, Link: tag present, content matches — passed
tag-check
✅
Commit subject starts with FROMLIST: — valid prefix for branch tech/all/dt/pakala
❌ dtb-check — FALSE POSITIVE
Root cause: The PR inserts one line (mode-switch;) into sm8750.dtsi, shifting all subsequent line numbers by +1; the checker's grep -vFf diff treats the same pre-existing graph_endpoint warning at the new line number as a newly introduced error.
Failure details:
# base build (pre-PR):
../arch/arm64/boot/dts/qcom/sm8750.dtsi:2823.36-2825.8: Warning (graph_endpoint):
/soc@0/phy@88e8000/ports/port@2/endpoint: graph connection to node
'/soc@0/display-subsystem@ae00000/displayport-controller@af54000/ports/port@1/endpoint'
is not bidirectional
# head build (post-PR) — identical warning, line shifted by 1:
../arch/arm64/boot/dts/qcom/sm8750.dtsi:2824.36-2826.8: Warning (graph_endpoint):
/soc@0/phy@88e8000/ports/port@2/endpoint: graph connection to node
'/soc@0/display-subsystem@ae00000/displayport-controller@af54000/ports/port@1/endpoint'
is not bidirectional
Log Summary: Test failed
The warning node path (/soc@0/phy@88e8000/ports/port@2/endpoint) and message are identical in both builds. Only the source line number differs (2823 → 2824) because mode-switch; was inserted one line above. The grep -vFf comparison is line-number-sensitive, so it incorrectly surfaces this as a new error.
This PR does not introduce any new DT graph connectivity issue. The graph_endpoint bidirectionality warning between phy@88e8000/ports/port@2 and displayport-controller@af54000/ports/port@1 is a pre-existing tree issue in sm8750.dtsi unrelated to the mode-switch property addition.
Fix: No patch change needed. Re-trigger CI — the failure is a checker infrastructure false positive caused by line-number-sensitive diff. If the tree-wide graph_endpoint issue needs addressing, that is a separate pre-existing concern.
Reproduce locally:
# Build base and head DTBs and compare warnings (ignoring line numbers):
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/sm8750.dtb 2>&1 \
| grep graph_endpoint | sed 's/:[0-9]*\.[0-9]*-[0-9]*\.[0-9]*:/:<line>:/'
Verdict
No real blocker. The single dtb-check failure is a false positive caused by a 1-line source shift in sm8750.dtsi after inserting mode-switch;. All other checkers pass or are correctly skipped. The PR is ready to merge — re-trigger CI to confirm the false positive clears, or accept the known line-shift artifact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
qcomlnxci
requested review from
a team,
knaveen-qc,
quicAspratap and
rrnayak
and removed request for
a team
Allow mode-switch events to reach the QMP Combo PHY to support
setting the QMP Combo PHY in DP 4Lanes Altmode.