QCLINUX: arm64: dts: qcom: add hamoa CAMX EL2 overlay

[michael-jihan-qcom]

Add a device tree overlay to enable EL2 boot support for the
Hamoa platform with CAMX configuration.

CRs-Fixed: 4538425

[quic-vikramsa]

remove this

[sgaud-quic]

PR #1161 — validate-patch

PR: #1161

Verdict	Issues	Detailed Report
✅	0	Full report

Verdict: ✅ — click to expand

🔍 Patch Validation

PR: QCLINUX: arm64: dts: qcom: add hamoa CAMX EL2 overlay — PR #1161
Upstream commit: N/A — QCLINUX: prefix; no upstream lore link expected or required
Verdict: ✅ PASS

---

Scope note: The commit carries a QCLINUX: prefix, which designates a vendor-only change with no upstream equivalent. Per the validate-patch skill rules, lore.kernel.org diff comparison and upstream-status checks are not applicable. The report below covers commit-message correctness, authorship/tag hygiene, and diff self-consistency only.

---

Commit Message

Check	Status	Note
Subject matches prefix convention	✅	QCLINUX: arm64: dts: qcom: add hamoa CAMX EL2 overlay — correct subsystem path and imperative verb
Body preserves rationale	✅	Two-sentence body clearly states purpose: EL2 boot support for Hamoa/CAMX
Fixes tag present/correct	N/A	No regression fix; CRs-Fixed: 4538425 is the appropriate vendor tracker tag
Authorship preserved	✅	From: and sole Signed-off-by: are the same person (mignatiu@qti.qualcomm.com) — correct for a single-author vendor commit
Backport note	N/A	Not a backport
Co-developed-by misuse	✅	Not present; no issue
Lore Link: tag	N/A	QCLINUX: commits have no upstream lore link by design

---

Diff

File	Status	Notes
arch/arm64/boot/dts/qcom/Makefile	✅	Adds hamoa-camx-el2-dtbs composite rule and two dtb-$(CONFIG_ARCH_QCOM) lines; context lines match surrounding hamoa-evk-camx block pattern correctly
arch/arm64/boot/dts/qcom/hamoa-camx-el2.dtso	✅	New file; SPDX BSD-3-Clause, correct Qualcomm copyright, valid DT overlay structure (/dts-v1/; /plugin/;), single fragment@0 targeting /soc@0/qcom,cam-icp with iommus override

Makefile composite DTB rule review:

hamoa-camx-el2-dtbs  := hamoa-iot-evk-el2.dtb hamoa-evk-camx.dtbo hamoa-camx-el2.dtbo

This correctly chains the EL2 base DTB (hamoa-iot-evk-el2.dtb), the existing CAMX overlay (hamoa-evk-camx.dtbo), and the new EL2-specific overlay (hamoa-camx-el2.dtbo) — consistent with the adjacent hamoa-evk-camx-dtbs pattern.

---

Issues

None identified.

---

qcom-next Presence

⏭️ Skipped — QCLINUX: vendor-only commits are not expected in the upstream qcom-next branch; check not applicable.

---

Upstream Patch Status

⏭️ Skipped — QCLINUX: prefix; no upstream posting exists by design.

---

Verdict

Clean vendor-only commit: commit message, authorship, SPDX/copyright, Makefile rule, and DTS overlay content are all correct and self-consistent — merge as-is.

[sgaud-quic]

PR #1161 — checker-log-analyzer

PR: #1161
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/25921034505

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	0 errors, 0 warnings — clean
dt-binding-check	⏭️	No changes in Documentation/devicetree/bindings — skipped
dtb-check	❌	New DTB validation errors in hamoa-camx-el2.dtb
sparse-check	⏭️	No C/H changes — skipped
check-uapi-headers	⏭️	No relevant changes — skipped
check-patch-compliance	❌	QCLINUX: prefix not in allowed list
tag-check	✅	QCLINUX: is a valid vendor prefix for tech/overlay/dt
qcom-next-check	N/A	Not a qcom-next target branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: QCLINUX: arm64: dts: qcom: add hamoa CAMX EL2 overlay (#1161)
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/25921034505
Target branch: tech/overlay/dt (not qcom-next / qcom-next-staging → tag-check is mandatory)

Checker	Result	Summary
checkpatch	✅	0 errors, 0 warnings — clean
dt-binding-check	⏭️	No changes in Documentation/devicetree/bindings — skipped
dtb-check	❌	New DTB validation errors in hamoa-camx-el2.dtb
sparse-check	⏭️	No C/H changes — skipped
check-uapi-headers	⏭️	No relevant changes — skipped
check-patch-compliance	❌	QCLINUX: prefix not in allowed list
tag-check	✅	QCLINUX: is a valid vendor prefix for tech/overlay/dt
qcom-next-check	N/A	Not a qcom-next target branch

---

❌ dtb-check

Root cause: The new hamoa-camx-el2.dtb composite DTB (assembled from hamoa-iot-evk.dtb + hamoa-evk-camx.dtbo + hamoa-camx-el2.dtbo) fails schema validation because the CAMX nodes inherited from hamoa-camera.dtsi are missing ranges properties required by simple-bus.yaml, and several CAMX-specific compatible strings (qcom,cam-res-mgr, qcom,cam-sync, qcom,camera_x1e80100, qcom,msm-cam-smmu, qcom,msm-cam-smmu-cb) have no matching upstream binding schema.

Failure details (new errors only — confirmed via grep -vFf base_dtbs_errors.log head_dtbs_errors.log):

hamoa-camx-el2.dtb: soc@0 (simple-bus): qcom,cam-icp: 'ranges' is a required property
  from schema $id: http://devicetree.org/schemas/simple-bus.yaml#
hamoa-camx-el2.dtb: soc@0 (simple-bus): qcom,cam-smmu: 'ranges' is a required property
hamoa-camx-el2.dtb: soc@0 (simple-bus): qcom,cam-sync: 'ranges' is a required property
hamoa-camx-el2.dtb: soc@0 (simple-bus): qcom,cam-req-mgr: 'ranges' is a required property
hamoa-camx-el2.dtb: soc@0 (simple-bus): qcom,cam-cdm-intf: 'ranges' is a required property
hamoa-camx-el2.dtb: soc@0 (simple-bus): qcom,camera-main: 'ranges' is a required property
hamoa-camx-el2.dtb: soc@0 (simple-bus): qcom,cam-res-mgr: 'ranges' is a required property
hamoa-camx-el2.dtb: soc@0 (simple-bus): qcom,cam-jpeg: 'ranges' is a required property
hamoa-camx-el2.dtb: soc@0 (simple-bus): qcom,cam-isp: 'ranges' is a required property
hamoa-camx-el2.dtb: /soc@0/qcom,cam-res-mgr: failed to match any schema with compatible: ['qcom,cam-res-mgr']
hamoa-camx-el2.dtb: /soc@0/qcom,camera-main: failed to match any schema with compatible: ['qcom,camera_x1e80100']
hamoa-camx-el2.dtb: /soc@0/qcom,cam-sync: failed to match any schema with compatible: ['qcom,cam-sync']
hamoa-camx-el2.dtb: /soc@0/qcom,cam-smmu: failed to match any schema with compatible: ['qcom,msm-cam-smmu', 'simple-bus']
hamoa-camx-el2.dtb: /soc@0/qcom,cam-smmu/msm-cam-smmu-*: failed to match any schema with compatible: ['qcom,msm-cam-smmu-cb']
Log Summary: Test failed

Analysis:

These errors are not caused by the new hamoa-camx-el2.dtso file itself (which only adds an iommus property to qcom,cam-icp). They are surfaced because the new composite DTB hamoa-camx-el2.dtb = hamoa-iot-evk.dtb + hamoa-evk-camx.dtbo + hamoa-camx-el2.dtbo causes the checker to validate the full merged tree, exposing pre-existing issues in hamoa-camera.dtsi (the hamoa-evk-camx.dtbo component) that were not previously caught because hamoa-evk-camx.dtb was not validated as a composite DTB in the base tree.

Two categories of issues:

1. ranges missing on CAMX bus nodes — The CAMX nodes (qcom,cam-icp, qcom,cam-smmu, etc.) in hamoa-camera.dtsi are children of soc@0 (a simple-bus). The simple-bus schema requires child bus nodes that have sub-nodes with reg to declare ranges. These nodes are missing ranges = <>; (or equivalent). This is a pre-existing defect in hamoa-camera.dtsi now exposed by the new composite DTB.

2. failed to match any schema — Compatible strings qcom,cam-res-mgr, qcom,cam-sync, qcom,camera_x1e80100, qcom,msm-cam-smmu, qcom,msm-cam-smmu-cb have no upstream DT binding YAML. These are vendor-only CAMX driver bindings not submitted upstream.

Fix options:

Option A (preferred — suppress known pre-existing issues):
If the hamoa-evk-camx.dtb composite was already passing dtb-check before this PR, these errors are pre-existing in hamoa-camera.dtsi and should be tracked separately. Verify whether hamoa-evk-camx.dtb was in the base-tree dtb-check scope. If not, the PR author should either:

• Fix hamoa-camera.dtsi to add ranges = <>; to each CAMX bus node that has sub-nodes with reg, OR
• Accept that these are known pre-existing issues in the CAMX vendor tree and document them.

Option B (minimal fix for the new DTB only):
The hamoa-camx-el2.dtso overlay itself is correct. The failures come from the base hamoa-evk-camx.dtbo component. No change to hamoa-camx-el2.dtso will fix these errors — the fix must go into hamoa-camera.dtsi.

Concrete fix for the ranges errors in hamoa-camera.dtsi:
For each CAMX node that is a child of soc@0 and contains sub-nodes with reg properties, add:

ranges;

Example for qcom,cam-icp@ac01000:

qcom,icp@ac01000 {
    compatible = "qcom,cam-icp";
    ranges;          /* add this */
    ...
};

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/hamoa-camx-el2.dtb

---

❌ check-patch-compliance

Root cause: The commit subject starts with QCLINUX:, which is not in the check-patch-compliance allowed prefix list — this is a known checker limitation for vendor-only commits with no upstream equivalent.

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: add hamoa CAMX EL2 overlay
Commit summary does not start with a required prefix
Process completed with exit code 1.

Analysis:
The QCLINUX: prefix correctly identifies this as a vendor-only change (no upstream equivalent). The check-patch-compliance checker does not accept QCLINUX: as a valid prefix — this is a known limitation documented in the skill. The commit itself is correctly tagged for the tech/overlay/dt branch.

Fix:
This failure is expected and unavoidable for QCLINUX: commits. No patch change is needed. The checker will always fail for vendor-only commits using QCLINUX:. This should be acknowledged as a known false-positive for this PR.

If the patch is ever posted upstream (e.g., to the DT mailing list), change the prefix to FROMLIST: and add a Link: trailer pointing to the lore.kernel.org thread.

Reproduce locally:

# check-patch-compliance always fails for QCLINUX: prefixed commits — no local reproduction needed

---

Verdict

2 blockers — but only 1 requires a patch fix:

• dtb-check ❌ — Genuine new DTB validation failures in hamoa-camx-el2.dtb. The ranges property is missing on CAMX bus nodes in hamoa-camera.dtsi, and several CAMX compatible strings lack upstream binding schemas. These are pre-existing issues in hamoa-camera.dtsi now exposed by the new composite DTB. The author should either fix hamoa-camera.dtsi (add ranges; to CAMX bus nodes) or confirm these are accepted pre-existing tree-wide issues before merging.

• check-patch-compliance ❌ — Known false-positive for QCLINUX: vendor-only commits. No patch change needed; this failure is expected and can be waived.