[CallbackEvents] Unit tests#65
[CallbackEvents] Unit tests#65cotid-qualabs wants to merge 9 commits intofeature/callback-eventsfrom
Conversation
tatiana-perera
changed the title
| */ | ||
| function _sendCallbackRequest(event) { | ||
| try { | ||
| const url = event.parsedMessageData ?? event.value; |
There was a problem hiding this comment.
Why should we remove this?
I think that this is needed for inlineEvents. When an event is inline, it doesn't have the parsedMessageData, and the URL value is in the event.value.
There was a problem hiding this comment.
On src/dash/DashAdapter.js line 499 we changed the value of messageData (which then is used to get parsedMessageData) to fix a bug where message_data was undefined, because value was received instead. In order to prevent errors, the logic to define which value to use (message_data or value) was moved to the Dash Adapter, so that decision is made before reaching src/streaming/controllers/EventController.js line 547 in this case. At this current point parsedMessageData is either message_data or value, depending the workflow.
test/unit/test/streaming/streaming.controllers.EventController.js
Outdated
Show resolved
Hide resolved
sebastianpiq
changed the title
Co-authored-by: Sebastian Piquerez <89274285+sebastianpiq@users.noreply.github.com>
Co-authored-by: Sebastian Piquerez <89274285+sebastianpiq@users.noreply.github.com>
Co-authored-by: Sebastian Piquerez <89274285+sebastianpiq@users.noreply.github.com>
3 participants
No description provided.